Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #85

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Update dependencies #85

merged 8 commits into from
Oct 18, 2023

Conversation

yuhsianw
Copy link
Collaborator

@yuhsianw yuhsianw commented Sep 28, 2023

This fixes all install, lint, test, and build warnings & errors ✨

Changes:

  • Update dependencies: Babel, ESLint, Chai, and Nodemon.
  • Add ESLint plugin for Mocha.
  • Fix all lint errors.
  • Remove unused dependencies.

@yuhsianw yuhsianw changed the base branch from master to frankwang/update-test-runners September 28, 2023 01:59
@yuhsianw yuhsianw marked this pull request as ready for review September 28, 2023 02:12
@yuhsianw yuhsianw added the dependencies Pull requests that update a dependency file label Sep 28, 2023
@@ -3,7 +3,7 @@ import { RuleTester as EslintRuleTester } from 'eslint';
import { test } from 'mocha';

/* pattern taken from eslint-plugin-import */
export function addFilenameOption(testCase) {
export function addFilenameOption (testCase) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A linter made you add a whitespace here?! That's odd 🤔

Copy link
Collaborator Author

@yuhsianw yuhsianw Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a rule in the eslint-plugin-standard preset. Planning on changing the style later though.

@yuhsianw yuhsianw force-pushed the frankwang/update-test-runners branch from b9add69 to 7581b2e Compare October 17, 2023 17:29
@yuhsianw yuhsianw force-pushed the frankwang/update-dependencies branch from 7e1931c to 1a766ae Compare October 18, 2023 13:29
@yuhsianw yuhsianw force-pushed the frankwang/update-dependencies branch from 1a766ae to 7402c25 Compare October 18, 2023 13:57
Base automatically changed from frankwang/update-test-runners to master October 18, 2023 14:11
@yuhsianw yuhsianw merged commit 99b3ad1 into master Oct 18, 2023
@yuhsianw yuhsianw deleted the frankwang/update-dependencies branch October 18, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants