TST: Update matrix #174
Merged
TST: Update matrix #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
=======================================
Coverage 89.87% 89.87%
=======================================
Files 27 27
Lines 1146 1146
=======================================
Hits 1030 1030
Misses 116 116 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bsipocz
approved these changes
Aug 10, 2023
|
Maybe also add a py312 to the dev testing? (or maybe add that separately as it may require some fixes first) |
|
I can try add 3.12 but if it fails for reasons we cannot control, I'll take it back out. |
and update RTD config
TST: Install setuptools for tests in Python 3.12
pllim
force-pushed
the
update-ci-matrix
branch
from
b973381
to
680bf31
Compare
pllim
commented
Aug 10, 2023
| @@ -28,6 +28,7 @@ test = | |||
| pytest-cov | |||
| cython | |||
| coverage | |||
| setuptools;python_version>='3.12' | |||
There was a problem hiding this comment.
@bsipocz , I needed this for the Python 3.12-dev job to pass. Does this look right or is this a symptom of something else?
|
Anyway, why don't we merge this as-is. And we can revisit Python 3.12 job if what I did here isn't the way to go. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #173 by updating matrix. The compatibility was already addressed in #172 .