Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove ignore of reverted deprecation #171

Merged
merged 1 commit into from Jun 14, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jun 14, 2023

This deprecation warning has been reverted, so we shouldn't ignore the warning.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI passes. Thanks!

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #171 (7c299aa) into main (ae69f55) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          27       27           
  Lines        1141     1141           
=======================================
  Hits         1025     1025           
  Misses        116      116           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pllim pllim merged commit b389ee2 into astropy:main Jun 14, 2023
19 checks passed
@pllim pllim added this to the 0.16.0 milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants