Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automodsumm_included_members option, take2 #165

Merged
merged 1 commit into from Jan 29, 2024

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Apr 19, 2023

This is the rebased version of #103 (as that one was opened from an org fork, maintainers cannot directly push to it)

EDIT: close #121

@bsipocz bsipocz added this to the 0.16.0 milestone Apr 19, 2023
@bsipocz bsipocz force-pushed the unhide-class-methods branch 2 times, most recently from d701642 to 1e98e30 Compare April 20, 2023 01:05
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57e934e) 90.24% compared to head (033e007) 90.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          28       28           
  Lines        1179     1179           
=======================================
  Hits         1064     1064           
  Misses        115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@og113
Copy link

og113 commented Jul 18, 2023

Hi all, really appreciate the library you've made. This feature would be really useful to us, and it looks pretty much ready. Could someone possibly take a look and see if it can be merged please? Thank you :)

included in the documentation. This is most commonly used to add special class
methods like ``__getitem__`` and ``__setitem__``. Defaults to
``['__init__', '__call__']``.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit confusing to document this option in the automodapi module. Some options are documented in both modules, some other are not ...

@pllim pllim modified the milestones: 0.16.0, 0.17.0 Aug 17, 2023
@pllim
Copy link
Member

pllim commented Aug 17, 2023

This didn't make it to 0.16.0 . Looks like there is an unresolved comment?

@bsipocz
Copy link
Member Author

bsipocz commented Aug 17, 2023

and unresolved from the previous PR to add a test. pushes to the PR are welcome :)

@astrofrog astrofrog removed their request for review October 24, 2023 09:51
@bsipocz
Copy link
Member Author

bsipocz commented Jan 27, 2024

Rebased and I would not simmer this along much more, what about rolling a YOLO on it @pllim?

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Let's try it out.

@pllim pllim merged commit 04947b6 into astropy:main Jan 29, 2024
17 checks passed
@pllim
Copy link
Member

pllim commented Jan 29, 2024

Thanks, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants