New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automodsumm_included_members option, take2 #165
Conversation
d701642
to
1e98e30
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 28 28
Lines 1179 1179
=======================================
Hits 1064 1064
Misses 115 115 ☔ View full report in Codecov by Sentry. |
Hi all, really appreciate the library you've made. This feature would be really useful to us, and it looks pretty much ready. Could someone possibly take a look and see if it can be merged please? Thank you :) |
included in the documentation. This is most commonly used to add special class | ||
methods like ``__getitem__`` and ``__setitem__``. Defaults to | ||
``['__init__', '__call__']``. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit confusing to document this option in the automodapi
module. Some options are documented in both modules, some other are not ...
This didn't make it to 0.16.0 . Looks like there is an unresolved comment? |
and unresolved from the previous PR to add a test. pushes to the PR are welcome :) |
1e98e30
to
033e007
Compare
Rebased and I would not simmer this along much more, what about rolling a YOLO on it @pllim? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Let's try it out.
Thanks, all! |
This is the rebased version of #103 (as that one was opened from an org fork, maintainers cannot directly push to it)
EDIT: close #121