-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: adapt table representation tests to numpy 2 #16433
TST: adapt table representation tests to numpy 2 #16433
Conversation
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
👋 Thank you for your draft pull request! Do you know that you can use |
c866449
to
5b5b962
Compare
@@ -756,56 +757,104 @@ def test_quantity_representation(): | |||
] | |||
|
|||
|
|||
def test_representation_representation(): | |||
@pytest.mark.parametrize( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to reviewers: the diff is not minimal here because I started by refactoring as a parametrized test before I knew exactly how I was going to avoid duplication. In the end it's not necessary but I figure it doesn't hurt either, so I didn't undo it 🤷🏻♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactored version is harder to read by human though. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, happy to revert the non-essential part if requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see what @taldcroft says.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactor is OK. It is slightly less readable but I think that is outweighed by the benefit of having the tests separated so if one fails the rest still run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me for Table. @pllim is this good to merge, right milestone and all?
Damn, sorry I missed that. I looked up your PR a couple times for other changes and didn't find them there so I just stopped doing it just assumed it only dealt with docstring tests. |
5b5b962
to
3ffdf7e
Compare
The |
@mhvk , how should we proceed? Please advise. Thanks! |
I think this one is still waiting for response from @mhvk . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just get this in - it is a duplication of my PR, but it's handier to do it in small steps.
…433-on-v6.1.x Backport PR #16433 on branch v6.1.x (TST: adapt table representation tests to numpy 2)
Description
This pull request is to address part of #16423 (specifically table)
The first commit is shared with #16426 and #16427, so they can be merged in any order.