Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Pin sphinx<7.2 #15189

Merged
merged 1 commit into from
Aug 17, 2023
Merged

DOC: Pin sphinx<7.2 #15189

merged 1 commit into from
Aug 17, 2023

Conversation

pllim
Copy link
Member

@pllim pllim commented Aug 17, 2023 •
edited

Description

I got too optimistic at #15184 but looks like we're blocked by at least another upstream release that I have no control over (sphinx-gallery, for a start). So I think it is best we just pin sphinx<7.2 for now.

Also fix #15181

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v5.0.8 milestone Aug 17, 2023
@github-actions
Copy link

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added the Extra CI Run cron CI as part of PR label Aug 17, 2023
@pllim
Copy link
Member Author

pllim commented Aug 17, 2023

pre-commit.ci autofix

@pllim
DOC: Pin sphinx<7.2
f48baa1 
until upstream is less messy

DOC: Fix linkcheck in cosmology API
from ECSV rendering
@pllim pllim marked this pull request as ready for review August 17, 2023 19:59
@pllim pllim requested a review from a team as a code owner August 17, 2023 19:59
@pllim pllim requested a review from nstarman August 17, 2023 19:59
@pllim
Copy link
Member Author

pllim commented Aug 17, 2023

Coverage upload failed. It probably flagged my many commits today as spam. We can ignore the coverage complain here.

@pllim
Copy link
Member Author

pllim commented Aug 17, 2023

Come back to me, sweet sweet green check marks!

@pllim pllim merged commit b3c7572 into astropy:main Aug 17, 2023
28 of 33 checks passed
@lumberbot-app

This comment was marked as resolved.

Sign in to view
@lumberbot-app

This comment was marked as resolved.

Sign in to view
@pllim pllim deleted the really-pin-sphinx-now branch August 17, 2023 20:17
pllim added a commit to pllim/astropy that referenced this pull request Aug 17, 2023
@pllim
Backport PR astropy#15189: DOC: Pin sphinx<7.2
4a0f44b
@pllim pllim mentioned this pull request Aug 17, 2023
Merged
1 task
pllim added a commit to pllim/astropy that referenced this pull request Aug 17, 2023
@pllim
Backport PR astropy#15189: DOC: Pin sphinx<7.2
252419f 
and also fix devdocs failure
@pllim pllim mentioned this pull request Aug 17, 2023
Merged
1 task
pllim added a commit that referenced this pull request Aug 17, 2023
@pllim
Merge pull request #15191 from pllim/backport-of-pr-15189-on-v5.3.x
54f7b5c 
Backport PR #15189 on branch v5.3.x (DOC: Pin sphinx<7.2)
pllim added a commit that referenced this pull request Aug 17, 2023
@pllim
Merge pull request #15192 from pllim/backport-of-pr-15189-on-v5.0.x
2563e0f 
Backport PR #15189 on branch v5.0.x (DOC: Pin sphinx<7.2) and fix devdeps
@pllim pllim mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstarman nstarman nstarman approved these changes

Assignees
No one assigned
Labels
Docs Extra CI Run cron CI as part of PR installation no-changelog-entry-needed Upstream Fix Required 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.3.x on-merge: backport to v5.3.x
Projects
None yet
Milestone
v5.0.8
Development

Successfully merging this pull request may close these issues.

DOC: cosmology doc has broken link
2 participants
@pllim @nstarman