Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test (again) docs build with sphinx-automodapi fork that fixes the inheritance-diagram links #15104

Closed
wants to merge 2 commits into from

Conversation

ayshih
Copy link
Contributor

@ayshih ayshih commented Jul 31, 2023

sphinx-doc/sphinx#10614 has now been merged. The remaining broken inheritance-diagram links needs a fix in sphinx-automodapi: astropy/sphinx-automodapi#172

Original post:

This is a test PR to confirm that the pending Sphinx PR sphinx-doc/sphinx#10614 to fix the bug with links in inheritance diagrams does in fact fix the issue in Astropy's docs (#4935). Do not merge this PR.

There's renewed activity on the Sphinx PR, but my previous test PR (#13357) apparently can't be re-opened.

@github-actions github-actions bot added the Docs label Jul 31, 2023
@github-actions
Copy link

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@ayshih
Copy link
Contributor Author

ayshih commented Jul 31, 2023

Apparently what I should have done for reopening the old PR was first reopen and then rebase, not first rebase and then reopen. Oh well, I've already created this new PR.

@ayshih ayshih changed the title Test (again) docs build with Sphinx fork that fixes the inheritance-diagram links Test (again) docs build with sphinx-automodapi fork that fixes the inheritance-diagram links Aug 10, 2023
@ayshih
Copy link
Contributor Author

ayshih commented Aug 19, 2023

Closing because it is no longer needed

@ayshih ayshih closed this Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant