Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOT: Avoid labeler from removing labels #12632

Merged
merged 1 commit into from Dec 29, 2021
Merged

Conversation

pllim
Copy link
Member

@pllim pllim commented Dec 24, 2021

Description

This pull request is to tell labeler action to not remove labels, only add them. A workaround as per actions/labeler#112 (comment) . Won't really know if it works after merge and the use case that triggers it happens (in our case, we'll never see labels getting removed by the bot anymore no matter what).

No point to run CI here.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@saimn saimn closed this Dec 29, 2021
@saimn saimn reopened this Dec 29, 2021
@pllim pllim merged commit c994e22 into astropy:main Dec 29, 2021
@pllim pllim deleted the labeler-no-sync branch December 29, 2021 18:01
@pllim
Copy link
Member Author

pllim commented Dec 29, 2021

Thanks for the approval!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants