Use jyear format instead of decimalyear in apply_space_motion example #11023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm @pllim the GH actions labeler got a little presumptuous here in removing the docs label! |
|
Wow, I didn't know it can remove a label! I'll have to investigate. Sorry for the trouble and thanks for letting me know. |
|
I wonder if it is a race condition that is not handled properly by that action. Does not seem like something I can fix on our side. I opened actions/labeler#112 . In the meantime, try apply your own labels after the action is done. Sorry for the inconvenience. 😬 |
|
@adrn - looks all OK, but shouldn't this be backported to LTS? Or was the example not there? |
|
Oh yes, likely so - I believe this was there and I just mixed up versions! |
bsipocz
pushed a commit
that referenced
this pull request
Nov 23, 2020
Use jyear format instead of decimalyear in apply_space_motion example
bsipocz
pushed a commit
that referenced
this pull request
Nov 23, 2020
Use jyear format instead of decimalyear in apply_space_motion example
bsipocz
pushed a commit
that referenced
this pull request
Nov 23, 2020
Use jyear format instead of decimalyear in apply_space_motion example
bsipocz
pushed a commit
that referenced
this pull request
Nov 25, 2020
Use jyear format instead of decimalyear in apply_space_motion example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11009
As @tboch uncovered and @eerovaher figured out, the example fixed in this PR incorrectly used the decimalyear time format for parsing the Gaia epoch '2015.5', which lead to some confusion when comparing
apply_space_motion()to other epoch propagation algorithms.