Skip to content

Commit

Permalink
Lift the limit on importlib_resources library (apache#38294)
Browse files Browse the repository at this point in the history
The problem with importlib_resources interacting badly with
pytest_rewrite has been solved in 6.3.2 version today and we can
simply skip over the bad versions.

See python/importlib_resources#298
  • Loading branch information
potiuk authored and utkarsharma2 committed Apr 22, 2024
1 parent ae87a04 commit 63dc96c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion dev/breeze/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@ PLEASE DO NOT MODIFY THE HASH BELOW! IT IS AUTOMATICALLY UPDATED BY PRE-COMMIT.

---------------------------------------------------------------------------------------------------------

Package config hash: dc6668558ff6f7334e9f9a7ff9073caccd790d4ff4aab0e1228b3363677b53714310d4a2b9b43ff3e089c34fb3cdc9861350d1a495299feb3bb12c7506574c77
Package config hash: fb5183650b0efb5ec8241fcd53b6e5cc26c21c8d273fff91d0e8a3716f37703c44c7ae189653dd3fd52624d89c97635e0a7fc09104138ba35cb3ccf45f8efd4b

---------------------------------------------------------------------------------------------------------
4 changes: 2 additions & 2 deletions dev/breeze/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ dependencies = [
"flit>=3.5.0",
"gitpython>=3.1.40",
"hatch==1.9.1",
# Importib_resources 6.2.0 break pytest_rewrite
# Importib_resources 6.2.0-6.3.1 break pytest_rewrite
# see https://github.com/python/importlib_resources/issues/299
"importlib_resources>=5.2,<6.2.0;python_version<\"3.9\"",
"importlib_resources>=5.2,!=6.2.0,!=6.3.0,!=6.3.1;python_version<\"3.9\"",
"inputimeout>=1.0.4",
"jinja2>=3.1.0",
"jsonschema>=4.19.1",
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ dependencies = [
"gunicorn>=20.1.0",
"httpx",
"importlib_metadata>=1.7;python_version<\"3.9\"",
# Importib_resources 6.2.0 break pytest_rewrite
# Importib_resources 6.2.0-6.3.1 break pytest_rewrite
# see https://github.com/python/importlib_resources/issues/299
"importlib_resources>=5.2,<6.2.0;python_version<\"3.9\"",
"importlib_resources>=5.2,!=6.2.0,!=6.3.0,!=6.3.1;python_version<\"3.9\"",
"itsdangerous>=2.0",
"jinja2>=3.0.0",
"jsonschema>=4.18.0",
Expand Down

0 comments on commit 63dc96c

Please sign in to comment.