Add initial implementation of uv tool run
#3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
May 19, 2024
zanieb
force-pushed
the
zb/tool-run
branch
2 times, most recently
from
92dd1dd
to
68e4a18
Compare
| uv_virtualenv::Prompt::None, | ||
| false, | ||
| false, | ||
| )?; |
There was a problem hiding this comment.
Ultimately, will these be installed in some sort of global directory that's also exposed on PATH, either by adding at install time or via some kind of ensurepath?
There was a problem hiding this comment.
Ok, I see this in #3560 now. If the tool is already installed in the user environment, it will be used, but uv tool run on its own will not install the tool. Is that correct?
There was a problem hiding this comment.
Yeah uv tool run will not install a tool. It could cache the environment and will support detecting user-installed and project-level tools but we don't have those yet here. I've already started a branch for uv tool install — it's just much more complex as a starting point.
zanieb
added a commit
that referenced
this pull request
May 20, 2024
Prompted by #3657 (comment) There's still some level of discomfort here, as the `tool` module needs needs to import the `project` module to manage an environment. We should probably move most of the basic operations in the `project` module root into some sort of shared module for behind the scenes operations? Regardless, this change should simplify that future move.
zanieb
force-pushed
the
zb/tool-run
branch
2 times, most recently
from
32ae0db
to
fdcab26
Compare
# Conflicts: # crates/uv/src/commands/mod.rs # crates/uv/src/commands/project/run.rs # Conflicts: # crates/uv/src/commands/project/mod.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a shorter version of
uv runthat infers a requirement name from the command. The main goal here is to do the smallest amount of work necessary to get #3560 started.Closes #3613
e.g.