Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract local versions from direct URL requirements #2624

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Extract local versions from direct URL requirements #2624

merged 1 commit into from
Mar 22, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #2623.

Test Plan

cargo run pip install -r requirements.txt, with:

 whisperX @ https://github.com/m-bain/whisperX/archive/befe2b242eb59dcd7a8a122d127614d5c63d36e9.zip
 pyannote-audio @ git+https://github.com/pyannote/pyannote-audio@11b56a137a578db9335efc00298f6ec1932e6317
 torch @ https://download.pytorch.org/whl/cu118/torch-2.2.1%2Bcu118-cp311-cp311-linux_x86_64.whl#sha256=84328a35621cc6a67a182a327baaab67e5f5869981c4b1677ed05f92c15cceb1
 torchaudio @ https://download.pytorch.org/whl/cu118/torchaudio-2.2.1%2Bcu118-cp311-cp311-linux_x86_64.whl#sha256=cd3b1c3582b17792c6d7a367dea0459b123e54d7a4242809ea87ccc10fa220e5
 pytorch_triton @ https://download.pytorch.org/whl/nightly/pytorch_triton-2.1.0%2B7d1a95b046-cp311-cp311-linux_x86_64.whl

@charliermarsh charliermarsh force-pushed the charlie/locals-url branch 2 times, most recently from af9a40b to d4aab5a Compare March 22, 2024 21:18
@charliermarsh charliermarsh marked this pull request as ready for review March 22, 2024 21:18
@charliermarsh charliermarsh added the bug Something isn't working label Mar 22, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) March 22, 2024 21:28
zanieb
zanieb approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@charliermarsh charliermarsh merged commit 90a1f89 into main Mar 22, 2024
31 checks passed
@zanieb
Copy link
Member

zanieb commented Mar 22, 2024

Sounds close to an enhancement to me.

@charliermarsh charliermarsh deleted the charlie/locals-url branch March 22, 2024 21:34
@charliermarsh charliermarsh mentioned this pull request Mar 27, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support local version identifiers from direct URL references
2 participants
@charliermarsh @zanieb