Always reinstall local source trees passed to `uv pip install` #12176

charliermarsh · 2025-03-14T20:15:13Z

Summary

This ended up being more involved than expected. The gist is that we setup all the packages we want to reinstall upfront (they're passed in on the command-line); but at that point, we don't have names for all the packages that the user has specified. (Consider, e.g., uv pip install . -- we don't have a name for ., so we can't add it to the list of Reinstall packages.)

Now, Reinstall also accepts paths, so we can augment Reinstall based on the user-provided paths.

Closes #12038.

zanieb · 2025-03-17T18:39:36Z

crates/uv-cache/src/lib.rs

+                    || path.is_some_and(|path| {
+                        paths
+                            .iter()
+                            .any(|target| same_file::is_same_file(path, target).unwrap_or(true))


On failure we assume true and always invalidate? That seems surprising.

(I don't feel strongly, but am curious for your thinking here)

Removed it. I didn't realize it errors when one file doesn't exist; I just didn't think about it deeply, thanks!

zanieb · 2025-03-17T18:40:19Z

crates/uv-configuration/src/package_options.rs

-            Self::Packages(packages) => packages.contains(package_name),
+            Self::Packages(.., paths) => paths
+                .iter()
+                .any(|target| same_file::is_same_file(path, target).unwrap_or(true)),


See previous comment

zanieb

The pull request says "source trees" but this implementation is just local source trees, right? Can you change that?

Do we want to change this for remote source trees, i.e., Git repositories too? Should we add test coverage for that now?

charliermarsh · 2025-03-17T18:46:21Z

Yeah, just local source trees.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.6.5` -> `0.6.9` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.6.9`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#069) [Compare Source](astral-sh/uv@0.6.8...0.6.9) ##### Enhancements - Use `keyring --mode creds` when `authenticate = "always"` ([#12316](astral-sh/uv#12316)) - Fail with specific error message when no password is present and `authenticate = "always"` ([#12313](astral-sh/uv#12313)) ##### Bug fixes - Add boolish value parser for `UV_MANAGED_PYTHON` flags ([#12345](astral-sh/uv#12345)) - Make deserialization non-fatal when assessing source tree revisions ([#12319](astral-sh/uv#12319)) - Use resolver-returned wheel over alternate cached wheel ([#12301](astral-sh/uv#12301)) ##### Documentation - Add experimental `--torch-backend` to the PyTorch guide ([#12317](astral-sh/uv#12317)) - Fix `#keyring-provider` references in alternative index docs ([#12315](astral-sh/uv#12315)) - Fix `--directory` path in examples ([#12165](astral-sh/uv#12165)) ##### Preview changes - Automatically infer the PyTorch index via `--torch-backend=auto` ([#12070](astral-sh/uv#12070)) ### [`v0.6.8`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#068) [Compare Source](astral-sh/uv@0.6.7...0.6.8) ##### Enhancements - Add support for enabling all groups by default with `default-groups = "all"` ([#12289](astral-sh/uv#12289)) - Add simpler `--managed-python` and `--no-managed-python` flags for toggling Python preferences ([#12246](astral-sh/uv#12246)) ##### Performance - Avoid allocations for default cache keys ([#12063](astral-sh/uv#12063)) ##### Bug fixes - Allow local version mismatches when validating lockfile ([#12285](astral-sh/uv#12285)) - Allow owned string when deserializing `requires-python` ([#12278](astral-sh/uv#12278)) - Make cache errors non-fatal in `Planner::build` ([#12281](astral-sh/uv#12281)) ### [`v0.6.7`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#067) [Compare Source](astral-sh/uv@0.6.6...0.6.7) ##### Python - Add CPython 3.14.0a6 - Fix regression where extension modules would use wrong `CXX` compiler on Linux - Enable FTS3 enhanced query syntax for SQLite See the [`python-build-standalone` release notes](https://github.com/astral-sh/python-build-standalone/releases/tag/20250317) for more details. ##### Enhancements - Add support for `-c` constraints in `uv add` ([#12209](astral-sh/uv#12209)) - Add support for `--global` default version in `uv python pin` ([#12115](astral-sh/uv#12115)) - Always reinstall local source trees passed to `uv pip install` ([#12176](astral-sh/uv#12176)) - Render token claims on publish permission error ([#12135](astral-sh/uv#12135)) - Add pip-compatible `--group` flag to `uv pip install` and `uv pip compile` ([#11686](astral-sh/uv#11686)) ##### Preview features - Avoid creating duplicate directory entries in built wheels ([#12206](astral-sh/uv#12206)) - Allow overriding module names for editable builds ([#12137](astral-sh/uv#12137)) ##### Performance - Avoid replicating core-metadata field on `File` struct ([#12159](astral-sh/uv#12159)) ##### Bug fixes - Add `src` to default cache keys ([#12062](astral-sh/uv#12062)) - Discard insufficient fork markers ([#10682](astral-sh/uv#10682)) - Ensure `python pin --global` creates parent directories if missing ([#12180](astral-sh/uv#12180)) - Fix GraalPy abi tag parsing and discovery ([#12154](astral-sh/uv#12154)) - Remove extraneous script packages in `uv sync --script` ([#12158](astral-sh/uv#12158)) - Remove redundant `activate.bat` output ([#12160](astral-sh/uv#12160)) - Avoid subsequent index hint when no versions are available on the first index ([#9332](astral-sh/uv#9332)) - Error on lockfiles with incoherent wheel versions ([#12235](astral-sh/uv#12235)) ##### Rust API - Update `BaseClientBuild` to accept custom proxies ([#12232](astral-sh/uv#12232)) ##### Documentation - Make testpypi index explicit in example snippet ([#12148](astral-sh/uv#12148)) - Reverse and format the archived changelogs ([#12099](astral-sh/uv#12099)) - Use consistent commas around i.e. and e.g. ([#12157](astral-sh/uv#12157)) - Fix typos in MRE docs ([#12198](astral-sh/uv#12198)) - Fix double space typo ([#12171](astral-sh/uv#12171)) ### [`v0.6.6`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#066) [Compare Source](astral-sh/uv@0.6.5...0.6.6) ##### Python - Add support for dynamic musl Python distributions on x86-64 Linux ([#12121](astral-sh/uv#12121)) - Allow the experimental JIT to be enabled at runtime on Python 3.13 and 3.14 on Linux - Upgrade the build toolchain to LLVM 20, improving performance See the [`python-build-standalone` release notes](https://github.com/astral-sh/python-build-standalone/releases/tag/20250311) for more details. ##### Enhancements - Add `--marker` flag to `uv add` ([#12012](astral-sh/uv#12012)) - Allow overriding module name for uv build backend ([#11884](astral-sh/uv#11884)) - Sync latest Python releases ([#12120](astral-sh/uv#12120)) - Use 'Upload' instead of 'Download' in publish reporter ([#12029](astral-sh/uv#12029)) - Add `[index].authenticate` allowing authentication to be required on an index ([#11896](astral-sh/uv#11896)) - Add support for Windows legacy scripts in `uv tool run` ([#12079](astral-sh/uv#12079)) - Propagate conflicting dependency groups when using `include-group` ([#12005](astral-sh/uv#12005)) - Show ambiguous requirements when `uv add` failed ([#12106](astral-sh/uv#12106)) ##### Performance - Cache workspace discovery ([#12096](astral-sh/uv#12096)) - Insert dependencies into fork state prior to fetching metadata ([#12057](astral-sh/uv#12057)) - Remove some allocations from `uv-auth` ([#12077](astral-sh/uv#12077)) ##### Bug fixes - Avoid considering `PATH` updated when the `export` is commented in the shellrc ([#12043](astral-sh/uv#12043)) - Fix `uv publish` retry on network failures ([#12041](astral-sh/uv#12041)) - Use a sized stream in `uv publish` to comply with WSGI PyPI server constraints ([#12111](astral-sh/uv#12111)) - Fix `uv python install --reinstall` when the version was not previously installed ([#12124](astral-sh/uv#12124)) ##### Preview features - Fix `uv_build` invocation ([#12058](astral-sh/uv#12058)) ##### Documentation - Quote versions string in `python-versions.md` ([#12112](astral-sh/uv#12112)) - Fix tool concept page headings ([#12053](astral-sh/uv#12053)) - Update the `[index].authenticate` docs ([#12102](astral-sh/uv#12102)) - Update versioning policy ([#11666](astral-sh/uv#11666)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

charliermarsh temporarily deployed to release March 14, 2025 20:15 — with GitHub Actions Inactive

charliermarsh added the no-build label Mar 14, 2025

charliermarsh force-pushed the charlie/explicit branch from 07ad594 to 2e977a2 Compare March 14, 2025 20:15

charliermarsh added enhancement cache labels Mar 14, 2025

charliermarsh requested review from zanieb and konstin March 14, 2025 20:16

charliermarsh force-pushed the charlie/explicit branch 6 times, most recently from c8935ae to db7d652 Compare March 15, 2025 20:55

konstin approved these changes Mar 17, 2025

View reviewed changes

zanieb reviewed Mar 17, 2025

View reviewed changes

charliermarsh force-pushed the charlie/explicit branch from db7d652 to dc2002f Compare March 17, 2025 18:42

zanieb approved these changes Mar 17, 2025

View reviewed changes

zanieb changed the title ~~Always reinstall source trees passed to uv pip install~~ Always reinstall local source trees passed to uv pip install Mar 17, 2025

Always reinstall source trees passed to uv pip install

Verified

This commit was signed with the committer’s verified signature.

dtolnay David Tolnay

GPG key ID: F9BA143B95FF6D82

Verified
Learn about vigilant mode

Loading
Loading status checks…

c001216

charliermarsh force-pushed the charlie/explicit branch from dc2002f to c001216 Compare March 17, 2025 21:03

charliermarsh enabled auto-merge (squash) March 17, 2025 21:08

charliermarsh merged commit 72be5ff into main Mar 17, 2025
90 checks passed

charliermarsh deleted the charlie/explicit branch March 17, 2025 21:12

BrewTestBot mentioned this pull request Mar 18, 2025

uv 0.6.7 Homebrew/homebrew-core#211299

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Always reinstall local source trees passed to `uv pip install` #12176

Always reinstall local source trees passed to `uv pip install` #12176

charliermarsh commented Mar 14, 2025 •

edited

Loading

zanieb Mar 17, 2025

zanieb Mar 17, 2025

charliermarsh Mar 17, 2025

zanieb Mar 17, 2025

zanieb left a comment

charliermarsh commented Mar 17, 2025

Always reinstall local source trees passed to uv pip install #12176

Always reinstall local source trees passed to uv pip install #12176

Conversation

charliermarsh commented Mar 14, 2025 • edited Loading

Summary

zanieb Mar 17, 2025

Choose a reason for hiding this comment

zanieb Mar 17, 2025

Choose a reason for hiding this comment

charliermarsh Mar 17, 2025

Choose a reason for hiding this comment

zanieb Mar 17, 2025

Choose a reason for hiding this comment

zanieb left a comment

Choose a reason for hiding this comment

charliermarsh commented Mar 17, 2025

Always reinstall local source trees passed to `uv pip install` #12176

Always reinstall local source trees passed to `uv pip install` #12176

charliermarsh commented Mar 14, 2025 •

edited

Loading