Add example demonstrating that fmt: skip on expression level is not supported
#9973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
approved these changes
Feb 13, 2024
MichaReiser
force-pushed
the
document-fmt-skip-expression-level
branch
2 times, most recently
from
73894e0
to
8848517
Compare
MichaReiser
force-pushed
the
document-fmt-skip-expression-level
branch
from
8848517
to
7103b99
Compare
nkxxll
pushed a commit
to nkxxll/ruff
that referenced
this pull request
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The fact that ruff doesn't support expression level suppression comments while black does has caused some confusion.
We plan to add a lint rule warning against said suppression comments in #9899 but we should also improve our documentation to mention the limitation explicilty.
This PR adds such documentation to the suppression comments section.
Closes #8319
Test Plan