Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RUF028 to detect useless formatter suppression comments #9899

Merged
merged 13 commits into from
Feb 28, 2024
Merged

Implement RUF028 to detect useless formatter suppression comments #9899

merged 13 commits into from
Feb 28, 2024

Commits on Feb 23, 2024

  1. Move SuppressionKind and CommentLinePosition to ruff_python_trivia

    @snowsignal
    snowsignal committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    d3bc248 View commit details
    Browse the repository at this point in the history

  2. Draft implementation of RUF028. Several edge cases still need to be r… 

    …esolved, particularly with dangling comments.
    @snowsignal
    snowsignal committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    fd65789 View commit details
    Browse the repository at this point in the history

  3. Continuing implementation of RUF028. Several edge cases have been add… 

    …ressed and several new problems are now reported. Edge cases involving dangling comments still need to be handled
    @snowsignal
    snowsignal committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f413bd5 View commit details
    Browse the repository at this point in the history

  4. Correctly attach end-of-body comments to the body and ignore invalid … 

    …comments when determining suppression state
    @snowsignal
    snowsignal committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    61d7e10 View commit details
    Browse the repository at this point in the history

  5. Fix parse error in RUF028 docs

    @snowsignal
    snowsignal committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    dcd9fef View commit details
    Browse the repository at this point in the history

  6. Update ruff.schema.json

    @snowsignal
    snowsignal committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b1539af View commit details
    Browse the repository at this point in the history

  7. Revise the language and messages for RUF028

    @snowsignal
    snowsignal committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    809d182 View commit details
    Browse the repository at this point in the history

  8. Fix formatting

    @snowsignal
    snowsignal committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    03db750 View commit details
    Browse the repository at this point in the history

  9. Address some suggestions

    @snowsignal
    snowsignal committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    0271500 View commit details
    Browse the repository at this point in the history

  10. Address remaining suggestions and reduce scope of lint by removing ru… 

    …le checks that need contextual information
    @snowsignal
    snowsignal committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    dad765d View commit details
    Browse the repository at this point in the history

  11. Fix inverted logic for is_suppression_on/is_suppression_off

    @snowsignal
    snowsignal committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    5ab92d8 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Address suggestions

    @snowsignal
    snowsignal committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    5b80da0 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Fix trailing comment visitation and add coverage for trailing skip co… 

    …mments on function definitions
    @snowsignal
    snowsignal committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    8fc186e View commit details
    Browse the repository at this point in the history