Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error if nursery rules are selected without preview #9683

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Error if nursery rules are selected without preview #9683

merged 5 commits into from
Jan 30, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jan 29, 2024 •
edited

Extends #9682 to error if the nursery selector is used or nursery rules are selected without preview.

Part of #7992 — we will remove this in 0.3.0 instead so we can provide nice errors in 0.2.0.

@zanieb zanieb force-pushed the zb/nursery-err-020 branch 2 times, most recently from a43f9b1 to 7435d3f Compare January 29, 2024 18:48
@zanieb zanieb added this to the v0.2.0 milestone Jan 29, 2024
@zanieb zanieb mentioned this pull request Jan 29, 2024
Merged
zanieb added a commit that referenced this pull request Jan 29, 2024
@zanieb
Error if the NURSERY selector is used with preview (#9682)
4ccbacd 
Changes our warning for combined use of `--preview` and `--select
NURSERY` to a hard error.

This should go out _before_ #9680 where we will ban use of `NURSERY`
outside of preview as well (see #9683).

Part of #7992
@zanieb zanieb marked this pull request as ready for review January 29, 2024 21:08
@zanieb zanieb mentioned this pull request Jan 29, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error) 

ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB131
	- RUF017
	- FURB113
	- FURB132

Linter (preview)

✅ ecosystem check detected no linter changes.

@zanieb zanieb mentioned this pull request Jan 30, 2024
Merged
@zanieb zanieb merged commit 0d543f0 into release/0.2.0 Jan 30, 2024
17 checks passed
@zanieb zanieb deleted the zb/nursery-err-020 branch January 30, 2024 15:27
zanieb added a commit that referenced this pull request Jan 30, 2024
@zanieb
Error if nursery rules are selected without preview (#9683)
07c6a3e 
Extends #9682 to error if the nursery selector is used or nursery rules
are selected without preview.

Part of #7992 — we will remove this in 0.3.0 instead so we can provide
nice errors in 0.2.0.
zanieb added a commit that referenced this pull request Feb 1, 2024
@zanieb
Error if nursery rules are selected without preview (#9683)
7c644d5 
Extends #9682 to error if the nursery selector is used or nursery rules
are selected without preview.

Part of #7992 — we will remove this in 0.3.0 instead so we can provide
nice errors in 0.2.0.
# Conflicts:
#	crates/ruff/tests/integration_test.rs
#	crates/ruff_workspace/src/configuration.rs
zanieb added a commit that referenced this pull request Feb 1, 2024
@zanieb
Error if nursery rules are selected without preview (#9683)
a0f32df 
Extends #9682 to error if the nursery selector is used or nursery rules
are selected without preview.

Part of #7992 — we will remove this in 0.3.0 instead so we can provide
nice errors in 0.2.0.
# Conflicts:
#	crates/ruff/tests/integration_test.rs
#	crates/ruff_workspace/src/configuration.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zanieb @MichaReiser