Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a rule/autofix to sort __slots__ and __match_args__ #9564

Merged
merged 23 commits into from
Jan 22, 2024
Merged

Add a rule/autofix to sort __slots__ and __match_args__ #9564

merged 23 commits into from
Jan 22, 2024

Commits on Jan 17, 2024

  1. [Proof of concept] Add a rule/autofix to sort __slots__ and `__matc… 

    …h_args__`
    @AlexWaygood
    AlexWaygood committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8a15678 View commit details
    Browse the repository at this point in the history

  2. Spruce up a little bit

    @AlexWaygood
    AlexWaygood committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    785a002 View commit details
    Browse the repository at this point in the history

  3. regenerate schema

    @AlexWaygood
    AlexWaygood committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    dfeb341 View commit details
    Browse the repository at this point in the history

  4. Respond to some Micha comments from Discord

    @AlexWaygood
    AlexWaygood committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    39a059b View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Avoid allocations in the common case

    @AlexWaygood
    AlexWaygood committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    37ee879 View commit details
    Browse the repository at this point in the history

  2. Also implement the fix for multiline __slots__ and __match_args__

    @AlexWaygood
    AlexWaygood committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    883b561 View commit details
    Browse the repository at this point in the history

  3. remove some unnecessary uses of pub

    @AlexWaygood
    AlexWaygood committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    270432f View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. use static lifetimes 

    Co-authored-by: Micha Reiser <micha@reiser.io>
    @AlexWaygood @MichaReiser
    AlexWaygood and MichaReiser committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    6c94446 View commit details
    Browse the repository at this point in the history

  2. Address a bunch of Micha comments

    @AlexWaygood
    AlexWaygood committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    90c413b View commit details
    Browse the repository at this point in the history

  3. Introduce a SortingStyle enum

    @AlexWaygood
    AlexWaygood committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    2b41a65 View commit details
    Browse the repository at this point in the history

  4. explicitly test an edge case

    @AlexWaygood
    AlexWaygood committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    902871a View commit details
    Browse the repository at this point in the history

  5. split the assertion in two

    @AlexWaygood
    AlexWaygood committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    b667d2f View commit details
    Browse the repository at this point in the history

  6. Rename NodeAnalysis

    @AlexWaygood
    AlexWaygood committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    cf6ca75 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. fix a few nits

    @AlexWaygood
    AlexWaygood committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    b04bdb0 View commit details
    Browse the repository at this point in the history

  2. Address some Charlie comments

    @AlexWaygood
    AlexWaygood committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    3dfdf8b View commit details
    Browse the repository at this point in the history

  3. Fix edge-case bug involving __slots__ or __all__ that have non-st… 

    …ring literals after a string literal that uses implicit concatenation
    @AlexWaygood
    AlexWaygood committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    606d85a View commit details
    Browse the repository at this point in the history

  4. More Charlie comments

    @AlexWaygood
    AlexWaygood committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    1f59a16 View commit details
    Browse the repository at this point in the history

  5. Make create_fix a method in sort_dunder_slots.rs

    @AlexWaygood
    AlexWaygood committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    e64879a View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Put all the validation logic for the elements into a newtype construc… 

    …tor method
    @AlexWaygood
    AlexWaygood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6645934 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into sort-dunder-slots

    @AlexWaygood
    AlexWaygood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    58bed1d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into sort-dunder-slots

    @AlexWaygood
    AlexWaygood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    7395585 View commit details
    Browse the repository at this point in the history

  4. Implement Clone and Copy for SortingStyle

    @AlexWaygood
    AlexWaygood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0ab0682 View commit details
    Browse the repository at this point in the history

  5. Small cleanups

    @AlexWaygood
    AlexWaygood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    333fe62 View commit details
    Browse the repository at this point in the history