[pylint] Implement potential-index-error (PLE0643)
#9545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
diceroll123
force-pushed
the
add-PLE0643
branch
from
d411cd4
to
652603a
Compare
|
It's quite common to deal with int64 array indices in machine learning and big data applications so I would recommend allow 64bit indices. Seems like the speed difference wouldn't be worth improperly handling these edge cases? |
|
I'd love to see a way for arbitrary integer comparisons here, but I don't think we'll be able to do that without adding dependencies. I'd love to be proven wrong, but I'd also argue that 64 bits is beyond plenty in this scenario. |
diceroll123
force-pushed
the
add-PLE0643
branch
from
12e059a
to
6ba0c85
Compare
diceroll123
force-pushed
the
add-PLE0643
branch
from
e3af85a
to
59ed7ba
Compare
diceroll123
force-pushed
the
add-PLE0643
branch
from
59ed7ba
to
9263644
Compare
charliermarsh
added
rule
charliermarsh
changed the title
pylint] - add potential-index-error rule (PLE0643)pylint] Implement potential-index-error (PLE0643)
|
Great tweaks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add
potential-index-errorrule (PLE0643)See: #970
Test Plan
cargo test