Ignore preview status for fixable and unfixable selectors #9538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Jan 15, 2024
| @@ -786,7 +786,7 @@ impl LintConfiguration { | |||
| .chain(selection.extend_fixable.iter()) | |||
| .filter(|s| s.specificity() == spec) | |||
| { | |||
| for rule in selector.rules(&preview) { | |||
| for rule in selector.all_rules() { | |||
There was a problem hiding this comment.
If we only apply the change to the initial let mut fixable_set: RuleSet = RuleSelector::All.all_rules().collect(), and not here, confusing things can happen... E.g. if you used select = ["RUF017"], then unfixable = ["RUF"] wouldn't mark RUF017 as unfixable, which seems confusing.
charliermarsh
added
bug
CodSpeed Performance ReportMerging #9538 will degrade performances by 4.33%Comparing Summary
Benchmarks breakdown
|
|
|
Gonna add a test prior to merging. |
charliermarsh
force-pushed
the
charlie/fix
branch
from
1fea5fd
to
37f42fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now, if you run with
explicit-preview-rules, and use something likeselect = ["RUF017"], we won't actually enable fixing for that rule, becausefixable = ["ALL"](the default) won't includeRUF017due to theexplicit-preview-rules.The framing in this PR is that
explicit-preview-rulesshould only affect the enablement selectors, whereas the fixable selectors should just include all possible matching rules. I think this will lead to the most intuitive behavior.Closes #9282. (An alternative to #9284.)