Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include base pyproject when initializing cache settings #9480

Merged
merged 1 commit into from Jan 12, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Regression from https://github.com/astral-sh/ruff/pull/9453/files#diff-80a9c2637c432502a7075c792cc60db92282dd786999a78bfa9bb6f025afab35L482.

Closes #9478.

Test Plan

rm -rf .ruff_cache
cargo run -p ruff_cli -- check ../foo.py

Failed prior to this PR; passes afterwards. The file must be outside of the current working directory, and must not have a pyproject.toml in any parent directory.

@charliermarsh charliermarsh marked this pull request as ready for review January 12, 2024 00:11
@charliermarsh charliermarsh added the bug Something isn't working label Jan 12, 2024
Copy link

codspeed-hq bot commented Jan 12, 2024

CodSpeed Performance Report

Merging #9480 will improve performances by 4.55%

Comparing charlie/resolver (1fd067d) with main (55f8f3b)

Summary

⚡ 1 improvements
✅ 29 untouched benchmarks

Benchmarks breakdown

Benchmark main charlie/resolver Change
parser[numpy/ctypeslib.py] 12.8 ms 12.2 ms +4.55%

@charliermarsh charliermarsh merged commit 350dcb8 into main Jan 12, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/resolver branch January 12, 2024 00:18
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to create cache file
1 participant