Avoid nested quotations in auto-quoting fix #9168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/unique
branch
from
2d7c14c
to
e666f4d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given
Callable[[Callable[_P, _R]], Callable[_P, _R]]from the originating issue, when quotingCallable, we quoted the inner[Callable[_P, _R]], and then created a separate edit for the outerCallable. Since there's an extra level of nesting in the subscript, the edit for[Callable[_P, _R]]correctly did not expand to the entire expression. However, in this case, we should discard the inner edit, since the expression is getting quoted by the outer edit anyway.Closes #9162.