can_omit_optional_parentheses: Exit early for unparenthesized expressions
#9125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
MichaReiser
added
internal
MichaReiser
force-pushed
the
can-omit-exit-early-for-expressions-without-parens
branch
from
3411a09
to
1f8f254
Compare
|
MichaReiser
deleted the
can-omit-exit-early-for-expressions-without-parens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
can_omit_optional_parentheseslayout tries to avoid parenthesizing an expression ifbreaking any of it's sub-expressions that have their own parentheses make the expression fit.
This PR moves the check whether an expression contains any parenthesized expression further up
to ensure we avoid the slightly more expensive layout when there are no other parentheses by which we can break.
Test Plan
ecosystem check reports no changes