[flake8-simplify] Omit select context managers from SIM117
#8801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Semantically it makes sense to put certain contextmanagers into separate with statements. Currently asyncio.timeout and its relatives in anyio and trio are exempt from SIM117. Closes astral-sh#8606
maltevesper
force-pushed
the
maltev/explicitWithBlockExceptions
branch
from
6fb0bf9
to
bcb447c
Compare
|
I have not figured out how to make ruff work if the context manager is assigned to a variable. A quick poke around revealed that x is a binding, but I did not see how to extract type information for x, given that ruff is a linter/formatter and not a typechecker I assume this functionality is currently not included. |
charliermarsh
changed the title
flake8-simplify] Omit select context managers from SIM117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semantically it makes sense to put certain contextmanagers into separate with statements. Currently asyncio.timeout and its relatives in anyio and trio are exempt from SIM117.
Closes #8606
Summary
Exempt asyncio.timeout and related functions from SIM117 (Collapse with statements where possible).
See #8606 for more.
Test Plan
Extended the insta tests.