Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement autofix for unnecessary-lambda (PLW0108) #8621

Merged
merged 1 commit into from Nov 11, 2023

Conversation

charliermarsh
Copy link
Member

Closes #8618.

@charliermarsh charliermarsh added the fixes Related to suggested fixes for violations label Nov 11, 2023
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -75 violations, +192 -0 fixes in 41 projects)

DisnakeDev/disnake (+0 -0 violations, +8 -0 fixes)

ruff check --no-cache --exit-zero --preview

- disnake/client.py:1261:52: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ disnake/client.py:1261:52: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- disnake/client.py:1262:53: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ disnake/client.py:1262:53: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- disnake/ext/commands/flag_converter.py:330:33: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ disnake/ext/commands/flag_converter.py:330:33: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- disnake/iterators.py:159:25: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ disnake/iterators.py:159:25: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function

apache/airflow (+0 -0 violations, +6 -0 fixes)

ruff check --no-cache --exit-zero --select ALL --preview

- dev/prepare_release_issue.py:268:46: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ dev/prepare_release_issue.py:268:46: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- scripts/ci/pre_commit/pre_commit_check_provider_docs.py:48:57: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ scripts/ci/pre_commit/pre_commit_check_provider_docs.py:48:57: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- scripts/ci/pre_commit/pre_commit_update_providers_dependencies.py:52:56: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ scripts/ci/pre_commit/pre_commit_update_providers_dependencies.py:52:56: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function

aws/aws-sam-cli (+0 -0 violations, +14 -0 fixes)

ruff check --no-cache --exit-zero --preview

- tests/unit/commands/local/lib/test_stack_provider.py:114:51: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ tests/unit/commands/local/lib/test_stack_provider.py:114:51: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- tests/unit/commands/local/lib/test_stack_provider.py:152:51: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ tests/unit/commands/local/lib/test_stack_provider.py:152:51: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- tests/unit/commands/local/lib/test_stack_provider.py:190:51: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ tests/unit/commands/local/lib/test_stack_provider.py:190:51: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- tests/unit/commands/local/lib/test_stack_provider.py:229:51: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ tests/unit/commands/local/lib/test_stack_provider.py:229:51: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- tests/unit/commands/local/lib/test_stack_provider.py:270:51: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ tests/unit/commands/local/lib/test_stack_provider.py:270:51: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
... 4 additional changes omitted for project

bokeh/bokeh (+0 -0 violations, +74 -0 fixes)

ruff check --no-cache --exit-zero --select ALL --preview

- src/bokeh/core/property/dataspec.py:201:71: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ src/bokeh/core/property/dataspec.py:201:71: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- src/bokeh/io/webdriver.py:217:17: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ src/bokeh/io/webdriver.py:217:17: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- src/bokeh/models/tools.py:1354:101: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ src/bokeh/models/tools.py:1354:101: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- src/bokeh/models/tools.py:1862:28: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ src/bokeh/models/tools.py:1862:28: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- src/bokeh/models/tools.py:1864:34: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ src/bokeh/models/tools.py:1864:34: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- src/bokeh/models/tools.py:1865:35: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ src/bokeh/models/tools.py:1865:35: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- src/bokeh/models/tools.py:1868:36: PLW0108 Lambda may be unnecessary; consider inlining inner function
... 61 additional changes omitted for project

freedomofpress/securedrop (+0 -0 violations, +2 -0 fixes)

ruff check --no-cache --exit-zero --preview

- securedrop/pretty_bad_protocol/gnupg.py:657:26: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ securedrop/pretty_bad_protocol/gnupg.py:657:26: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function

fronzbot/blinkpy (+0 -0 violations, +10 -0 fixes)

ruff check --no-cache --exit-zero --preview

- tests/test_blink_functions.py:191:13: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ tests/test_blink_functions.py:191:13: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- tests/test_sync_module.py:591:13: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ tests/test_sync_module.py:591:13: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- tests/test_util.py:146:13: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ tests/test_util.py:146:13: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- tests/test_util.py:160:13: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ tests/test_util.py:160:13: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- tests/test_util.py:177:13: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ tests/test_util.py:177:13: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function

ibis-project/ibis (+0 -0 violations, +48 -0 fixes)

ruff check --no-cache --exit-zero --preview

- docs/backends/app/backend_info_app.py:23:28: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ docs/backends/app/backend_info_app.py:23:28: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- ibis/backends/dask/execution/reductions.py:47:29: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ ibis/backends/dask/execution/reductions.py:47:29: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- ibis/backends/impala/tests/test_value_exprs.py:236:9: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ ibis/backends/impala/tests/test_value_exprs.py:236:9: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- ibis/backends/mssql/registry.py:198:30: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ ibis/backends/mssql/registry.py:198:30: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- ibis/backends/mysql/registry.py:231:13: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ ibis/backends/mysql/registry.py:231:13: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
... 38 additional changes omitted for project

pandas-dev/pandas (+0 -75 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

- asv_bench/benchmarks/groupby.py:907:49: PLW0108 Lambda may be unnecessary; consider inlining inner function
- asv_bench/benchmarks/io/csv.py:342:25: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/_testing/__init__.py:843:16: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/_testing/__init__.py:847:16: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/_testing/__init__.py:855:16: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/_testing/__init__.py:859:16: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/core/_numba/extensions.py:279:16: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/tests/apply/test_frame_apply.py:1049:25: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/tests/apply/test_frame_apply.py:1049:6: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/tests/apply/test_frame_apply_relabeling.py:68:22: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/tests/apply/test_series_apply.py:393:40: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/tests/apply/test_series_apply.py:411:36: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/tests/apply/test_series_apply.py:687:24: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/tests/arithmetic/test_period.py:1411:13: PLW0108 Lambda may be unnecessary; consider inlining inner function
... 61 additional changes omitted for project

sphinx-doc/sphinx (+0 -0 violations, +4 -0 fixes)

ruff check --no-cache --exit-zero --preview

- sphinx/util/cfamily.py:110:32: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ sphinx/util/cfamily.py:110:32: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- sphinx/writers/xml.py:21:33: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ sphinx/writers/xml.py:21:33: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function

zulip/zulip (+0 -0 violations, +26 -0 fixes)

ruff check --no-cache --exit-zero --select ALL --preview

- tools/lib/capitalization.py:152:26: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ tools/lib/capitalization.py:152:26: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- zerver/lib/bot_lib.py:44:49: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ zerver/lib/bot_lib.py:44:49: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- zerver/lib/bot_lib.py:45:51: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ zerver/lib/bot_lib.py:45:51: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- zerver/lib/cache_helpers.py:107:17: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ zerver/lib/cache_helpers.py:107:17: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
- zerver/lib/cache_helpers.py:96:9: PLW0108 Lambda may be unnecessary; consider inlining inner function
+ zerver/lib/cache_helpers.py:96:9: PLW0108 [*] Lambda may be unnecessary; consider inlining inner function
... 16 additional changes omitted for project

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PLW0108 267 0 75 192 0

@charliermarsh charliermarsh merged commit 9724dfd into main Nov 11, 2023
17 checks passed
@charliermarsh charliermarsh deleted the charlie/lambda-fix branch November 11, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autofix PLW0108 unnecessary-lambda (preview)
1 participant