[E721] Flag comparisons to memoryview
#8485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
charliermarsh
approved these changes
Nov 4, 2023
charliermarsh
force-pushed
the
feat/E721memoryview
branch
from
d39c922
to
0f92719
Compare
hauntsaninja
added a commit
to hauntsaninja/ruff
that referenced
this pull request
Nov 5, 2023
See astral-sh#8483. Generalised fix on top of astral-sh#8485 Based on the output of `print("\n".join(k for k, v in builtins.__dict__.items() if isinstance(v, type)))`
charliermarsh
pushed a commit
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
memoryviewto the list of typeclasses thatfn is_type()uses for type comparison checks so that it raises a violation ifis,is notorisinstance()are not used.Test Plan
Added examples to existing fixture
Issue Link
Closes: #8483