Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OneIndexed in NotebookIndex #7921

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Use OneIndexed in NotebookIndex #7921

merged 1 commit into from
Oct 13, 2023

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 11, 2023 •
edited

Summary

This PR refactors the NotebookIndex struct to use OneIndexed to make the
intent of the code clearer.

Test Plan

Update the existing test case and run cargo test to verify the change.

  • Verify --diff output
  • Verify the diagnostics output
  • Verify --show-source output

@dhruvmanila
Copy link
Member Author

dhruvmanila commented Oct 11, 2023 •
edited

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@dhruvmanila dhruvmanila mentioned this pull request Oct 11, 2023
Merged
@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Oct 11, 2023
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@dhruvmanila dhruvmanila marked this pull request as ready for review October 11, 2023 18:39
@dhruvmanila dhruvmanila mentioned this pull request Oct 12, 2023
Merged
@dhruvmanila dhruvmanila merged commit cd564c4 into main Oct 13, 2023
16 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/notebook-one-indexed branch October 13, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

@charliermarsh charliermarsh Awaiting requested review from charliermarsh

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhruvmanila @konstin