Allow named expressions in __all__ assignments

crates/ruff_linter/resources/test/fixtures/pylint/invalid_all_format.py

@@ -20,6 +20,8 @@
 
 __all__ = foo["bar"]  # [invalid-all-format]
 
+__all__ = (foo := bar)  # [invalid-all-format]
+
 __all__ = ["Hello"]
 
 __all__ = ("Hello",)
@@ -41,3 +43,7 @@
 __all__ = __all__ + multiprocessing.__all__
 
 __all__ = list[str](["Hello", "world"])
+
+__all__ = list[str](foo())
+
+__all__ = (foo := ["Hello", "world"])

crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLE0605_invalid_all_format.py.snap

@@ -106,7 +106,27 @@ invalid_all_format.py:21:1: PLE0605 Invalid format for `__all__`, must be `tuple
 21 | __all__ = foo["bar"]  # [invalid-all-format]
    | ^^^^^^^ PLE0605
 22 | 
-23 | __all__ = ["Hello"]
+23 | __all__ = (foo := bar)  # [invalid-all-format]
+   |
+
+invalid_all_format.py:23:1: PLE0605 Invalid format for `__all__`, must be `tuple` or `list`
+   |
+21 | __all__ = foo["bar"]  # [invalid-all-format]
+22 | 
+23 | __all__ = (foo := bar)  # [invalid-all-format]
+   | ^^^^^^^ PLE0605
+24 | 
+25 | __all__ = ["Hello"]
+   |
+
+invalid_all_format.py:23:12: PLE0605 Invalid format for `__all__`, must be `tuple` or `list`
+   |
+21 | __all__ = foo["bar"]  # [invalid-all-format]
+22 | 
+23 | __all__ = (foo := bar)  # [invalid-all-format]
+   |            ^^^ PLE0605
+24 | 
+25 | __all__ = ["Hello"]
    |
 
 

crates/ruff_python_ast/src/all.rs

@@ -81,17 +81,21 @@ where
                                 | Expr::Tuple(ast::ExprTuple { elts, .. }) => {
                                     return (Some(elts), DunderAllFlags::empty());
                                 }
-                                Expr::ListComp(_) | Expr::SetComp(_) | Expr::GeneratorExp(_) => {
-                                    // Allow comprehensions, even though we can't statically analyze
-                                    // them.
+                                _ => {
+                                    // We can't analyze other expressions, but they must be
+                                    // valid, since the `list` or `tuple` call will ultimately
+                                    // evaluate to a list or tuple.
                                     return (None, DunderAllFlags::empty());
                                 }
-                                _ => {}
                             }
                         }
                     }
                 }
             }
+            Expr::NamedExpr(ast::ExprNamedExpr { value, .. }) => {
+                // Allow, e.g., `__all__ += (value := ["A", "B"])`.
+                return extract_elts(value, is_builtin);
+            }
             _ => {}
         }
         (None, DunderAllFlags::INVALID_FORMAT)