Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Autofix to Fix #7657

Merged
merged 2 commits into from Sep 28, 2023
Merged

Rename Autofix to Fix #7657

merged 2 commits into from Sep 28, 2023

Conversation

konstin
Copy link
Member

@konstin konstin commented Sep 25, 2023

Summary Mostly mechanical symbol rename and search-and-replace, with small changes to the markdown docs to read better

@konstin
Copy link
Member Author

konstin commented Sep 25, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@@ -12,7 +12,7 @@ changelog:
- title: Rules
labels:
- rule
- autofix
- fix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this requires changing the label within GitHub once this merges.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little tricky as it seems like fix means the change is a bug fix. Do we use the autofix label in the changelog much anyway?

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm comfortable with this, but probably worth getting at least one more approval before moving forward. I would also be interested in Zanie's opinion as the point person on CLI and applicability and such.

@konstin konstin requested a review from zanieb September 25, 2023 17:19
@zanieb
Copy link
Member

zanieb commented Sep 25, 2023

I'll try to review this tomorrow morning!

@MichaReiser
Copy link
Member

MichaReiser commented Sep 26, 2023

Makes sense to me, considering that we'll have "Autofix" with applicability "Manual". I defer to @zanieb for the final review

@konstin
Copy link
Member Author

konstin commented Sep 26, 2023

What's the decision on what to do with the labels, should we keep them as-is?

@zanieb
Copy link
Member

zanieb commented Sep 26, 2023

I don't think we need to generate a section for the fix label — seems safe to remove.

@charliermarsh
Copy link
Member

Yeah, I think it's fine to remove from the release notes. Do we want to remove the label entirely though? I'm fine with that too.

@zanieb
Copy link
Member

zanieb commented Sep 26, 2023

Yeah, I think it's fine to remove from the release notes. Do we want to remove the label entirely though? I'm fine with that too.

It kind of makes sense in the "Issue" section so seems fine to rename to fix and keep for now? We can see if there's any practical confusion

**Summary** Mostly mechanical rename symbol, with small changes to the markdown docs to read better
@konstin konstin enabled auto-merge (squash) September 28, 2023 10:44
@konstin konstin merged commit 1e173f7 into main Sep 28, 2023
16 checks passed
@konstin konstin deleted the rename-autofix-to-fix branch September 28, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants