Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't suggest replacing builtin.open() with Path.open() if the latter doesn't support all options #7637

Merged
merged 2 commits into from Sep 26, 2023
Merged

Don't suggest replacing builtin.open() with Path.open() if the latter doesn't support all options #7637

merged 2 commits into from Sep 26, 2023

Commits on Sep 25, 2023

  1. Don't suggest replacing builtin.open() with Path.open() if the la… 

    …tter doesn't support all options

**Summary** Check that `closefd` and `opener` aren't being used with `builtin.open()` before suggesting `Path.open()` because pathlib doesn't support these arguments.

Closes #7620

**Test Plan** New cases in the fixture
    @konstin
    konstin committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    549c698 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Review

    @konstin
    konstin committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b64b4a1 View commit details
    Browse the repository at this point in the history