Rename ConfigProcessor to ConfigurationTransformer
#7536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
changed the title
ConfigProcessor to ConfigurationTransformrConfigProcessor to ConfigurationTransformer
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
MichaReiser
force-pushed
the
merge-settings-and-all-settings
branch
from
acd6576
to
22d29dd
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
This was referenced Sep 20, 2023
charliermarsh
approved these changes
Sep 20, 2023
MichaReiser
force-pushed
the
merge-settings-and-all-settings
branch
2 times, most recently
from
530dba0
to
49afb83
Compare
MichaReiser
force-pushed
the
rename-config-processor
branch
from
8db001f
to
27bb8da
Compare
MichaReiser
force-pushed
the
rename-config-processor
branch
from
27bb8da
to
20d16ae
Compare
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renames
ConfigProcessortoConfigurationTransformerand change the method to consume theConfigurationinstead of taking a mutable reference (for easier usage)Renames
OverridestoCliOverridesto make their usage explicit (although it would be possible to use the same struct for applying otherOverridesit is the only actual usage)Test Plan
cargo test