Update Stylist quote detection with new f-string token
#7328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2023
dhruvmanila
added
python312
This was referenced Sep 13, 2023
dhruvmanila
force-pushed
the
dhruv/issue-7292
branch
from
2cf76c2
to
0cf830d
Compare
dhruvmanila
force-pushed
the
dhruv/issue-7293
branch
from
13b6442
to
6af8fb4
Compare
dhruvmanila
force-pushed
the
dhruv/issue-7292
branch
from
0cf830d
to
deeca01
Compare
dhruvmanila
force-pushed
the
dhruv/issue-7293
branch
from
6af8fb4
to
4a0ad8c
Compare
dhruvmanila
force-pushed
the
dhruv/issue-7292
branch
from
deeca01
to
a8b5756
Compare
dhruvmanila
force-pushed
the
dhruv/issue-7293
branch
from
4a0ad8c
to
4d05889
Compare
dhruvmanila
force-pushed
the
dhruv/issue-7292
branch
from
a8b5756
to
4c2017e
Compare
dhruvmanila
force-pushed
the
dhruv/issue-7293
branch
from
4d05889
to
5c23131
Compare
dhruvmanila
force-pushed
the
dhruv/issue-7293
branch
from
5c23131
to
e22a65d
Compare
MichaReiser
approved these changes
Sep 14, 2023
dhruvmanila
added a commit
that referenced
this pull request
Sep 18, 2023
## Summary This PR updates `Stylist` quote detection to include the f-string tokens. As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings. ## Test Plan Add new test cases with f-strings. fixes: #7293
This was referenced Sep 18, 2023
dhruvmanila
added a commit
that referenced
this pull request
Sep 19, 2023
## Summary This PR updates `Stylist` quote detection to include the f-string tokens. As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings. ## Test Plan Add new test cases with f-strings. fixes: #7293
dhruvmanila
added a commit
that referenced
this pull request
Sep 20, 2023
## Summary This PR updates `Stylist` quote detection to include the f-string tokens. As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings. ## Test Plan Add new test cases with f-strings. fixes: #7293
dhruvmanila
added a commit
that referenced
this pull request
Sep 22, 2023
## Summary This PR updates `Stylist` quote detection to include the f-string tokens. As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings. ## Test Plan Add new test cases with f-strings. fixes: #7293
dhruvmanila
added a commit
that referenced
this pull request
Sep 22, 2023
## Summary This PR updates `Stylist` quote detection to include the f-string tokens. As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings. ## Test Plan Add new test cases with f-strings. fixes: #7293
This was referenced Sep 22, 2023
dhruvmanila
added a commit
that referenced
this pull request
Sep 22, 2023
## Summary This PR updates `Stylist` quote detection to include the f-string tokens. As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings. ## Test Plan Add new test cases with f-strings. fixes: #7293
dhruvmanila
added a commit
that referenced
this pull request
Sep 26, 2023
## Summary This PR updates `Stylist` quote detection to include the f-string tokens. As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings. ## Test Plan Add new test cases with f-strings. fixes: #7293
dhruvmanila
added a commit
that referenced
this pull request
Sep 27, 2023
## Summary This PR updates `Stylist` quote detection to include the f-string tokens. As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings. ## Test Plan Add new test cases with f-strings. fixes: #7293
dhruvmanila
added a commit
that referenced
this pull request
Sep 28, 2023
## Summary This PR updates `Stylist` quote detection to include the f-string tokens. As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings. ## Test Plan Add new test cases with f-strings. fixes: #7293
dhruvmanila
added a commit
that referenced
this pull request
Sep 29, 2023
## Summary This PR updates `Stylist` quote detection to include the f-string tokens. As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings. ## Test Plan Add new test cases with f-strings. fixes: #7293
dhruvmanila
added a commit
that referenced
this pull request
Sep 29, 2023
## Summary This PR updates `Stylist` quote detection to include the f-string tokens. As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings. ## Test Plan Add new test cases with f-strings. fixes: #7293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
Stylistquote detection to include the f-string tokens.As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings.
Test Plan
Add new test cases with f-strings.
fixes: #7293