Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERA100 to apply to commented dictionary items with trailing comments #6822

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Aug 23, 2023

Closes #6821

ERA100 was not raising on commented parts of dictionaries if it included another comment (such as a noqa clause). In cases where this comment was a noqa clause, RUF100 to be emitted since the noqa would have no effect. Here, we update ERA100 to raise even when there are trailing comments. This resolves the linked issue and increases the scope of ERA100. We could narrow the regular expression to only apply to noqa comments if we do not want to expand ERA100 however I think this change is within the spirit of the rule.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+6, -0, 0 error(s))

airflow (+4, -0)

+ airflow/example_dags/tutorial.py:59:9: ERA001 [*] Found commented-out code
+ airflow/example_dags/tutorial.py:60:9: ERA001 [*] Found commented-out code
+ airflow/example_dags/tutorial.py:61:9: ERA001 [*] Found commented-out code
+ airflow/example_dags/tutorial.py:62:9: ERA001 [*] Found commented-out code

zulip (+2, -0)

+ zerver/lib/push_notifications.py:172:9: ERA001 [*] Found commented-out code
+ zerver/lib/push_notifications.py:173:9: ERA001 [*] Found commented-out code

Rules changed: 1
Rule Changes Additions Removals
ERA001 6 6 0

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      3.5±0.04ms    11.5 MB/sec    1.00      3.5±0.06ms    11.5 MB/sec
formatter/numpy/ctypeslib.py               1.00    707.0±8.31µs    23.6 MB/sec    1.00    705.2±8.86µs    23.6 MB/sec
formatter/numpy/globals.py                 1.00     73.8±0.56µs    40.0 MB/sec    1.01     74.3±0.34µs    39.7 MB/sec
formatter/pydantic/types.py                1.00  1417.6±15.61µs    18.0 MB/sec    1.00  1424.6±10.07µs    17.9 MB/sec
linter/all-rules/large/dataset.py          1.00     10.4±0.02ms     3.9 MB/sec    1.01     10.4±0.05ms     3.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      2.8±0.01ms     5.9 MB/sec    1.00      2.8±0.01ms     5.9 MB/sec
linter/all-rules/numpy/globals.py          1.00    318.3±0.83µs     9.3 MB/sec    1.00    318.5±1.98µs     9.3 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.4±0.03ms     4.7 MB/sec    1.00      5.4±0.01ms     4.7 MB/sec
linter/default-rules/large/dataset.py      1.00      5.5±0.02ms     7.4 MB/sec    1.01      5.6±0.02ms     7.3 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1175.2±4.00µs    14.2 MB/sec    1.01   1183.0±4.36µs    14.1 MB/sec
linter/default-rules/numpy/globals.py      1.00    122.7±0.23µs    24.1 MB/sec    1.01    123.4±0.37µs    23.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      2.5±0.01ms    10.2 MB/sec    1.01      2.5±0.01ms    10.1 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      4.1±0.02ms    10.0 MB/sec    1.00      4.1±0.04ms    10.0 MB/sec
formatter/numpy/ctypeslib.py               1.00    792.8±6.33µs    21.0 MB/sec    1.00    793.1±7.06µs    21.0 MB/sec
formatter/numpy/globals.py                 1.00     81.1±0.94µs    36.4 MB/sec    1.00     81.4±1.18µs    36.2 MB/sec
formatter/pydantic/types.py                1.00  1636.9±14.33µs    15.6 MB/sec    1.00  1639.2±14.18µs    15.6 MB/sec
linter/all-rules/large/dataset.py          1.00     12.6±0.07ms     3.2 MB/sec    1.00     12.6±0.08ms     3.2 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.5±0.02ms     4.7 MB/sec    1.01      3.6±0.04ms     4.7 MB/sec
linter/all-rules/numpy/globals.py          1.00    364.6±5.15µs     8.1 MB/sec    1.00    366.2±5.35µs     8.1 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.6±0.06ms     3.8 MB/sec    1.00      6.6±0.07ms     3.8 MB/sec
linter/default-rules/large/dataset.py      1.00      7.0±0.03ms     5.8 MB/sec    1.00      7.0±0.06ms     5.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1470.7±13.38µs    11.3 MB/sec    1.00  1475.4±12.58µs    11.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    148.6±2.23µs    19.9 MB/sec    1.01    150.0±2.98µs    19.7 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.1±0.02ms     8.1 MB/sec    1.00      3.2±0.02ms     8.1 MB/sec

@zanieb zanieb changed the title Fix interactions between ERA100 noqa comments and RUF100 Fix interactions between ERA100 noqa comments in dictionaries and RUF100 Aug 23, 2023
@zanieb
Copy link
Member Author

zanieb commented Aug 23, 2023

The airflow additions look good (although they're in a tutorial and definitely intentional), zulip less so but the way they wrote that is pretty specific.

@zanieb zanieb marked this pull request as ready for review August 23, 2023 19:46
@zanieb zanieb added the bug Something isn't working label Aug 23, 2023
@zanieb zanieb changed the title Fix interactions between ERA100 noqa comments in dictionaries and RUF100 Update ERA100 to apply to commented dictionary items with trailing comments Aug 23, 2023
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanieb zanieb merged commit f2eb7bc into main Aug 25, 2023
17 checks passed
@zanieb zanieb deleted the fix/6821 branch August 25, 2023 16:02
zanieb added a commit that referenced this pull request Aug 25, 2023
Broken on merge of #6822 due to new test cases conflicting with the
addition of an applicability to RUF100 in #6827
renovate bot added a commit to ixm-one/pytest-cmake-presets that referenced this pull request Aug 25, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://beta.ruff.rs/docs)
([source](https://togithub.com/astral-sh/ruff),
[changelog](https://togithub.com/astral-sh/ruff/releases)) | `^0.0.285`
-> `^0.0.286` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.285/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.285/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>astral-sh/ruff (ruff)</summary>

###
[`v0.0.286`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.286)

[Compare
Source](https://togithub.com/astral-sh/ruff/compare/v0.0.285...v0.0.286)

<!-- Release notes generated using configuration in .github/release.yml
at v0.0.286 -->

#### What's Changed

##### New Rules

- \[`flake8-bugbear`] Update `function-call-in-argument-default`
(`B008`) to ignore arguments with immutable annotations by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6784
- \[`flake8-bugbear`] Update `mutable-argument-default` (`B006`) to use
`extend-immutable-calls` when determining if annotations are immutable
by [@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6781
- \[`flake8-pie`] Implement `unnecessary-range-start` (`PIE808`) by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#6690
- \[`flake8-pytest-style`] Add autofix for `PT014` by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#6698
- \[`pylint`] Implement `no-self-use` (`R6301`) by
[@&#8203;LaBatata101](https://togithub.com/LaBatata101) in
[astral-sh/ruff#6574
- \[`pylint`] Extend `repeated-equality-comparison-target` to check for
mixed orderings and Yoda conditions. by
[@&#8203;tjkuson](https://togithub.com/tjkuson) in
[astral-sh/ruff#6691

##### Settings

- Make isort's `detect-same-package` behavior configurable by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6833

##### Bug Fixes

- Apply RUF017 when start is passed via position by
[@&#8203;hauntsaninja](https://togithub.com/hauntsaninja) in
[astral-sh/ruff#6664
- Use `typing_extensions.TypeAlias` for PYI026 fixes on pre-3.10 by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6696
- Ignore multi-comparisons in `repeated-equality-comparison-target` by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6705
- Accept empty inner calls in C414 by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6725
- Allow next in FBT exclusions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6729
- Allow `ctypes.WinError()` in flake8-raise by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6731
- Ignore star imports when importing symbols in fixes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6743
- Support C419 autofixes for set comprehensions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6744
- Avoid attempting to fix unconventional submodule imports by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6745
- Don't trigger `eq-without-hash` when `__hash__` is explicitly set to
`None` by [@&#8203;LaBatata101](https://togithub.com/LaBatata101) in
[astral-sh/ruff#6739
- Avoid E231 if comma is at end-of-line by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6747
- Truncate some messages in diagnostics by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6748
- Fix isolation groups for unused imports by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6774
- Avoid fixing D200 for docstrings that end in escapes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6779
- Parenthesize expressions prior to LibCST parsing by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6742
- Fallback to end-of-file if ends in trailing continuation by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6789
- Confine repeated-equality-comparison-target to names and attributes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6802
- Fix `native-literals` handling of int literal with attribute access by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6792
- Fix `uncessary-coding-comment` fix when there's leading content by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6775
- Avoid attempting to fix PT018 in multi-statement lines by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6829
- Update ERA100 to apply to commented dictionary items with trailing
comments by [@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6822
- Avoid parsing other parts of a format specification if replacements
are present by [@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6858
- Avoid panic in unused arguments rule for parameter-free lambda by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6679
- Avoid `C417` for `lambda` with default and variadic parameters by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#6752
- Add `networkx` to conventional aliases by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6778
- Skip serializing cell ID if it's None by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#6851
- fix is_raw_string for multiple prefixes by
[@&#8203;davidszotten](https://togithub.com/davidszotten) in
[astral-sh/ruff#6865
- Add jupyter notebook cell ids in 4.5+ if missing by
[@&#8203;konstin](https://togithub.com/konstin) in
[astral-sh/ruff#6853

**Full Changelog**:
astral-sh/ruff@v0.0.285...v0.0.286

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jankatins added a commit to jankatins/pr-workflow-example that referenced this pull request Aug 26, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://beta.ruff.rs/docs)
([source](https://togithub.com/astral-sh/ruff),
[changelog](https://togithub.com/astral-sh/ruff/releases)) | `0.0.285`
-> `0.0.286` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.285/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.285/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>astral-sh/ruff (ruff)</summary>

###
[`v0.0.286`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.286)

[Compare
Source](https://togithub.com/astral-sh/ruff/compare/v0.0.285...v0.0.286)

<!-- Release notes generated using configuration in .github/release.yml
at v0.0.286 -->

#### What's Changed

##### New Rules

- \[`flake8-bugbear`] Update `function-call-in-argument-default`
(`B008`) to ignore arguments with immutable annotations by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6784
- \[`flake8-bugbear`] Update `mutable-argument-default` (`B006`) to use
`extend-immutable-calls` when determining if annotations are immutable
by [@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6781
- \[`flake8-pie`] Implement `unnecessary-range-start` (`PIE808`) by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#6690
- \[`flake8-pytest-style`] Add autofix for `PT014` by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#6698
- \[`pylint`] Implement `no-self-use` (`R6301`) by
[@&#8203;LaBatata101](https://togithub.com/LaBatata101) in
[astral-sh/ruff#6574
- \[`pylint`] Extend `repeated-equality-comparison-target` to check for
mixed orderings and Yoda conditions. by
[@&#8203;tjkuson](https://togithub.com/tjkuson) in
[astral-sh/ruff#6691

##### Settings

- Make isort's `detect-same-package` behavior configurable by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6833

##### Bug Fixes

- Apply RUF017 when start is passed via position by
[@&#8203;hauntsaninja](https://togithub.com/hauntsaninja) in
[astral-sh/ruff#6664
- Use `typing_extensions.TypeAlias` for PYI026 fixes on pre-3.10 by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6696
- Ignore multi-comparisons in `repeated-equality-comparison-target` by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6705
- Accept empty inner calls in C414 by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6725
- Allow next in FBT exclusions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6729
- Allow `ctypes.WinError()` in flake8-raise by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6731
- Ignore star imports when importing symbols in fixes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6743
- Support C419 autofixes for set comprehensions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6744
- Avoid attempting to fix unconventional submodule imports by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6745
- Don't trigger `eq-without-hash` when `__hash__` is explicitly set to
`None` by [@&#8203;LaBatata101](https://togithub.com/LaBatata101) in
[astral-sh/ruff#6739
- Avoid E231 if comma is at end-of-line by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6747
- Truncate some messages in diagnostics by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6748
- Fix isolation groups for unused imports by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6774
- Avoid fixing D200 for docstrings that end in escapes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6779
- Parenthesize expressions prior to LibCST parsing by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6742
- Fallback to end-of-file if ends in trailing continuation by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6789
- Confine repeated-equality-comparison-target to names and attributes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6802
- Fix `native-literals` handling of int literal with attribute access by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6792
- Fix `uncessary-coding-comment` fix when there's leading content by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6775
- Avoid attempting to fix PT018 in multi-statement lines by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6829
- Update ERA100 to apply to commented dictionary items with trailing
comments by [@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6822
- Avoid parsing other parts of a format specification if replacements
are present by [@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6858
- Avoid panic in unused arguments rule for parameter-free lambda by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6679
- Avoid `C417` for `lambda` with default and variadic parameters by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#6752
- Add `networkx` to conventional aliases by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6778
- Skip serializing cell ID if it's None by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#6851
- fix is_raw_string for multiple prefixes by
[@&#8203;davidszotten](https://togithub.com/davidszotten) in
[astral-sh/ruff#6865
- Add jupyter notebook cell ids in 4.5+ if missing by
[@&#8203;konstin](https://togithub.com/konstin) in
[astral-sh/ruff#6853

**Full Changelog**:
astral-sh/ruff@v0.0.285...v0.0.286

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/jankatins/pr-workflow-example).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
renovate bot added a commit to allenporter/flux-local that referenced this pull request Aug 26, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://beta.ruff.rs/docs)
([source](https://togithub.com/astral-sh/ruff),
[changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.285`
-> `==0.0.286` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.285/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.285/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>astral-sh/ruff (ruff)</summary>

###
[`v0.0.286`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.286)

[Compare
Source](https://togithub.com/astral-sh/ruff/compare/v0.0.285...v0.0.286)

<!-- Release notes generated using configuration in .github/release.yml
at v0.0.286 -->

#### What's Changed

##### New Rules

- \[`flake8-bugbear`] Update `function-call-in-argument-default`
(`B008`) to ignore arguments with immutable annotations by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6784
- \[`flake8-bugbear`] Update `mutable-argument-default` (`B006`) to use
`extend-immutable-calls` when determining if annotations are immutable
by [@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6781
- \[`flake8-pie`] Implement `unnecessary-range-start` (`PIE808`) by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#6690
- \[`flake8-pytest-style`] Add autofix for `PT014` by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#6698
- \[`pylint`] Implement `no-self-use` (`R6301`) by
[@&#8203;LaBatata101](https://togithub.com/LaBatata101) in
[astral-sh/ruff#6574
- \[`pylint`] Extend `repeated-equality-comparison-target` to check for
mixed orderings and Yoda conditions. by
[@&#8203;tjkuson](https://togithub.com/tjkuson) in
[astral-sh/ruff#6691

##### Settings

- Make isort's `detect-same-package` behavior configurable by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6833

##### Bug Fixes

- Apply RUF017 when start is passed via position by
[@&#8203;hauntsaninja](https://togithub.com/hauntsaninja) in
[astral-sh/ruff#6664
- Use `typing_extensions.TypeAlias` for PYI026 fixes on pre-3.10 by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6696
- Ignore multi-comparisons in `repeated-equality-comparison-target` by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6705
- Accept empty inner calls in C414 by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6725
- Allow next in FBT exclusions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6729
- Allow `ctypes.WinError()` in flake8-raise by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6731
- Ignore star imports when importing symbols in fixes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6743
- Support C419 autofixes for set comprehensions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6744
- Avoid attempting to fix unconventional submodule imports by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6745
- Don't trigger `eq-without-hash` when `__hash__` is explicitly set to
`None` by [@&#8203;LaBatata101](https://togithub.com/LaBatata101) in
[astral-sh/ruff#6739
- Avoid E231 if comma is at end-of-line by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6747
- Truncate some messages in diagnostics by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6748
- Fix isolation groups for unused imports by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6774
- Avoid fixing D200 for docstrings that end in escapes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6779
- Parenthesize expressions prior to LibCST parsing by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6742
- Fallback to end-of-file if ends in trailing continuation by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6789
- Confine repeated-equality-comparison-target to names and attributes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6802
- Fix `native-literals` handling of int literal with attribute access by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6792
- Fix `uncessary-coding-comment` fix when there's leading content by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6775
- Avoid attempting to fix PT018 in multi-statement lines by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6829
- Update ERA100 to apply to commented dictionary items with trailing
comments by [@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6822
- Avoid parsing other parts of a format specification if replacements
are present by [@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6858
- Avoid panic in unused arguments rule for parameter-free lambda by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6679
- Avoid `C417` for `lambda` with default and variadic parameters by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#6752
- Add `networkx` to conventional aliases by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6778
- Skip serializing cell ID if it's None by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#6851
- fix is_raw_string for multiple prefixes by
[@&#8203;davidszotten](https://togithub.com/davidszotten) in
[astral-sh/ruff#6865
- Add jupyter notebook cell ids in 4.5+ if missing by
[@&#8203;konstin](https://togithub.com/konstin) in
[astral-sh/ruff#6853

**Full Changelog**:
astral-sh/ruff@v0.0.285...v0.0.286

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/allenporter/flux-local).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to allenporter/pyrainbird that referenced this pull request Aug 27, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://beta.ruff.rs/docs)
([source](https://togithub.com/astral-sh/ruff),
[changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.285`
-> `==0.0.286` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.285/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.285/0.0.286?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>astral-sh/ruff (ruff)</summary>

###
[`v0.0.286`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.286)

[Compare
Source](https://togithub.com/astral-sh/ruff/compare/v0.0.285...v0.0.286)

<!-- Release notes generated using configuration in .github/release.yml
at v0.0.286 -->

#### What's Changed

##### New Rules

- \[`flake8-bugbear`] Update `function-call-in-argument-default`
(`B008`) to ignore arguments with immutable annotations by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6784
- \[`flake8-bugbear`] Update `mutable-argument-default` (`B006`) to use
`extend-immutable-calls` when determining if annotations are immutable
by [@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6781
- \[`flake8-pie`] Implement `unnecessary-range-start` (`PIE808`) by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#6690
- \[`flake8-pytest-style`] Add autofix for `PT014` by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#6698
- \[`pylint`] Implement `no-self-use` (`R6301`) by
[@&#8203;LaBatata101](https://togithub.com/LaBatata101) in
[astral-sh/ruff#6574
- \[`pylint`] Extend `repeated-equality-comparison-target` to check for
mixed orderings and Yoda conditions. by
[@&#8203;tjkuson](https://togithub.com/tjkuson) in
[astral-sh/ruff#6691

##### Settings

- Make isort's `detect-same-package` behavior configurable by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6833

##### Bug Fixes

- Apply RUF017 when start is passed via position by
[@&#8203;hauntsaninja](https://togithub.com/hauntsaninja) in
[astral-sh/ruff#6664
- Use `typing_extensions.TypeAlias` for PYI026 fixes on pre-3.10 by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6696
- Ignore multi-comparisons in `repeated-equality-comparison-target` by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6705
- Accept empty inner calls in C414 by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6725
- Allow next in FBT exclusions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6729
- Allow `ctypes.WinError()` in flake8-raise by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6731
- Ignore star imports when importing symbols in fixes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6743
- Support C419 autofixes for set comprehensions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6744
- Avoid attempting to fix unconventional submodule imports by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6745
- Don't trigger `eq-without-hash` when `__hash__` is explicitly set to
`None` by [@&#8203;LaBatata101](https://togithub.com/LaBatata101) in
[astral-sh/ruff#6739
- Avoid E231 if comma is at end-of-line by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6747
- Truncate some messages in diagnostics by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6748
- Fix isolation groups for unused imports by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6774
- Avoid fixing D200 for docstrings that end in escapes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6779
- Parenthesize expressions prior to LibCST parsing by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6742
- Fallback to end-of-file if ends in trailing continuation by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6789
- Confine repeated-equality-comparison-target to names and attributes by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6802
- Fix `native-literals` handling of int literal with attribute access by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6792
- Fix `uncessary-coding-comment` fix when there's leading content by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6775
- Avoid attempting to fix PT018 in multi-statement lines by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6829
- Update ERA100 to apply to commented dictionary items with trailing
comments by [@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6822
- Avoid parsing other parts of a format specification if replacements
are present by [@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6858
- Avoid panic in unused arguments rule for parameter-free lambda by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#6679
- Avoid `C417` for `lambda` with default and variadic parameters by
[@&#8203;dhruvmanila](https://togithub.com/dhruvmanila) in
[astral-sh/ruff#6752
- Add `networkx` to conventional aliases by
[@&#8203;zanieb](https://togithub.com/zanieb) in
[astral-sh/ruff#6778
- Skip serializing cell ID if it's None by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#6851
- fix is_raw_string for multiple prefixes by
[@&#8203;davidszotten](https://togithub.com/davidszotten) in
[astral-sh/ruff#6865
- Add jupyter notebook cell ids in 4.5+ if missing by
[@&#8203;konstin](https://togithub.com/konstin) in
[astral-sh/ruff#6853

**Full Changelog**:
astral-sh/ruff@v0.0.285...v0.0.286

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/allenporter/pyrainbird).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignoring commented-out code with noqa: ERA001 may still trigger RUF100
2 participants