Set default version to py38 #6444

rco-ableton · 2023-08-09T10:34:54Z

Summary

In #6397, the documentation was updated stating that the default target-version is now "py38", but the actual default value wasn't updated and remained py310. This commit updates the default value to match what the documentation says.

Test Plan

I ran cargo test, which passed for me, and cargo insta review, which claimed no snapshots needed to be reviewed.

In astral-sh#6397, the documentation was updated stating that the default target-version is now "py38", but the actual default value wasn't updated and remained py310. This commit updates the default value to match what the documentation says.

github-actions · 2023-08-09T10:45:23Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.03      9.3±0.21ms     4.4 MB/sec    1.00      9.0±0.23ms     4.5 MB/sec
formatter/numpy/ctypeslib.py               1.00  1798.9±45.40µs     9.3 MB/sec    1.00  1796.2±75.87µs     9.3 MB/sec
formatter/numpy/globals.py                 1.00   213.1±11.42µs    13.8 MB/sec    1.01   214.8±13.63µs    13.7 MB/sec
formatter/pydantic/types.py                1.02      3.9±0.17ms     6.5 MB/sec    1.00      3.9±0.14ms     6.6 MB/sec
linter/all-rules/large/dataset.py          1.00     12.3±0.28ms     3.3 MB/sec    1.01     12.4±0.36ms     3.3 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      3.3±0.10ms     5.1 MB/sec    1.00      3.2±0.09ms     5.2 MB/sec
linter/all-rules/numpy/globals.py          1.01   458.6±15.53µs     6.4 MB/sec    1.00   455.5±11.46µs     6.5 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.4±0.20ms     4.0 MB/sec    1.00      6.3±0.16ms     4.0 MB/sec
linter/default-rules/large/dataset.py      1.00      6.2±0.17ms     6.6 MB/sec    1.09      6.7±0.15ms     6.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1361.7±70.96µs    12.2 MB/sec    1.03  1404.6±41.19µs    11.9 MB/sec
linter/default-rules/numpy/globals.py      1.00    173.3±8.64µs    17.0 MB/sec    1.01    175.9±8.73µs    16.8 MB/sec
linter/default-rules/pydantic/types.py     1.00      2.8±0.07ms     9.2 MB/sec    1.08      3.0±0.08ms     8.5 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00     10.4±0.09ms     3.9 MB/sec    1.02     10.6±0.11ms     3.9 MB/sec
formatter/numpy/ctypeslib.py               1.00  1962.1±12.04µs     8.5 MB/sec    1.01  1977.8±14.85µs     8.4 MB/sec
formatter/numpy/globals.py                 1.00    199.1±2.56µs    14.8 MB/sec    1.02    202.4±6.31µs    14.6 MB/sec
formatter/pydantic/types.py                1.00      4.4±0.06ms     5.8 MB/sec    1.01      4.5±0.05ms     5.7 MB/sec
linter/all-rules/large/dataset.py          1.01     13.2±0.10ms     3.1 MB/sec    1.00     13.2±0.10ms     3.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.7±0.05ms     4.5 MB/sec    1.00      3.7±0.04ms     4.5 MB/sec
linter/all-rules/numpy/globals.py          1.00    378.1±7.28µs     7.8 MB/sec    1.00   378.9±10.58µs     7.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.0±0.07ms     3.7 MB/sec    1.00      7.0±0.09ms     3.7 MB/sec
linter/default-rules/large/dataset.py      1.00      7.2±0.06ms     5.7 MB/sec    1.00      7.2±0.06ms     5.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1465.5±18.00µs    11.4 MB/sec    1.00  1465.5±14.61µs    11.4 MB/sec
linter/default-rules/numpy/globals.py      1.00    146.5±2.04µs    20.1 MB/sec    1.00    146.8±2.03µs    20.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.2±0.02ms     8.0 MB/sec    1.00      3.2±0.03ms     8.0 MB/sec

charliermarsh · 2023-08-09T11:41:07Z

Thanks! Looks like we actually did miss this, though the original diff here again only updated documentation. I pushed a commit to this branch to update the default on the Rust side.

charliermarsh · 2023-08-09T11:52:55Z

Looks like we do need to update a bunch of tests here (since they assumed 3.10).

charliermarsh · 2023-08-09T12:02:24Z

crates/ruff/src/rules/flake8_use_pathlib/mod.rs

@@ -67,7 +69,7 @@ mod tests {
        let snapshot = format!("{}_{}", rule_code.noqa_code(), path.to_string_lossy());
        let diagnostics = test_path(
            Path::new("flake8_use_pathlib").join(path).as_path(),
-            &settings::Settings::for_rule(rule_code),
+            &settings::Settings::for_rule(rule_code).with_target_version(PythonVersion::latest()),


@zanieb - We should probably make this the default for Settings::for_rule, what do you think? (But we can hash out in separate PR, I'm just trying to get tests passing here.)

I agree that makes sense to me

charliermarsh · 2023-08-09T12:05:27Z

crates/ruff/src/settings/defaults.rs

@@ -24,7 +24,7 @@ pub const PREFIXES: &[RuleSelector] = &[
    RuleSelector::Linter(Linter::Pyflakes),
 ];

-pub const TARGET_VERSION: PythonVersion = PythonVersion::Py310;
+pub const TARGET_VERSION: PythonVersion = PythonVersion::Py38;


This is the relevant change.

Thanks, I'd missed this somehow 😅

zanieb · 2023-08-09T15:27:47Z

😮‍💨 Thanks for fixing my mistake!

@rco-ableton

## What's Changed This release fixes a few bugs, notably the previous release announced a breaking change where the default target Python version changed from 3.10 to 3.8 but it was not applied. Thanks to @rco-ableton for fixing this in #6444 ### Bug Fixes * Do not trigger `S108` if path is inside `tempfile.*` call by @dhruvmanila in #6416 * Do not allow on zero tab width by @tjkuson in #6429 * Fix false-positive in submodule resolution by @charliermarsh in #6435 ## New Contributors * @rco-ableton made their first contribution in #6444 **Full Changelog**: v0.0.283...v0.0.284

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `^0.0.281` -> `^0.0.284` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.284?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.284?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.281/0.0.284?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.281/0.0.284?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.284`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.284) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.283...v0.0.284) #### What's Changed This release fixes a few bugs, notably the previous release announced a breaking change where the default target Python version changed from 3.10 to 3.8 but the change was not applied. Thanks to [@rco-ableton](https://togithub.com/rco-ableton) for fixing this in [astral-sh/ruff#6444 ##### Bug Fixes - Do not trigger `S108` if path is inside `tempfile.*` call by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#6416 - Do not allow on zero tab width by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#6429 - Fix false-positive in submodule resolution by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6435 #### New Contributors - [@rco-ableton](https://togithub.com/rco-ableton) made their first contribution in [astral-sh/ruff#6444 **Full Changelog**: astral-sh/ruff@v0.0.283...v0.0.284 ### [`v0.0.283`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.283) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.282...v0.0.283)  #### What's Changed ##### Breaking Changes - Assume Python 3.8 instead of 3.10 for target version by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6397 ##### Rules - \[`flake8-pyi`] `PYI019`: Detects if a type variable is used instead of `Self` in return annotations by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#6204 - \[`flake8-pyi`] `PYI051`: Detects unions of `Literal` types by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#6215 - \[`flake8-pyi`] `PYI055`: Detects unions of `type`s by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#6316 - \[`pylint`] `E1300`: Detects invalid string format characters by [@silvanocerza](https://togithub.com/silvanocerza) in [astral-sh/ruff#6171 - \[`pyupgrade`] `UP040`: Upgrades type alias annotations to use PEP-695 syntax by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6289 ##### Rule Changes - \[`flake8-boolean-trap`] `FBT003`: Add `is_` and `is_not` to excluded functions by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6307 - \[`flake8-logging-format`] Allow capitalized names for logger candidate heuristic match by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6356 - \[`flake8-pyi`] Applicable rules are now checked non-stub code by [@andersk](https://togithub.com/andersk) in [astral-sh/ruff#6297 - `PYI013`: [`ellipsis-in-non-empty-class-body`](https://beta.ruff.rs/docs/rules/ellipsis-in-non-empty-class-body) - `PYI016`: [`duplicate-union-member`](https://beta.ruff.rs/docs/rules/duplicate-union-member) - `PYI018`: [`unused-private-type-var`](https://beta.ruff.rs/docs/rules/unused-private-type-var) - `PYI019`: [`custom-type-var-return-type`](https://beta.ruff.rs/docs/rules/custom-type-var-return-type) - `PYI024`: [`collections-named-tuple`](https://beta.ruff.rs/docs/rules/collections-named-tuple) - `PYI025`: [`unaliased-collections-abc-set-import`](https://beta.ruff.rs/docs/rules/unaliased-collections-abc-set-import) - `PYI030`: [`unnecessary-literal-union`](https://beta.ruff.rs/docs/rules/unnecessary-literal-union) - `PYI032`: [`any-eq-ne-annotation`](https://beta.ruff.rs/docs/rules/any-eq-ne-annotation) - `PYI034`: [`non-self-return-type`](https://beta.ruff.rs/docs/rules/non-self-return-type) - `PYI036`: [`bad-exit-annotation`](https://beta.ruff.rs/docs/rules/bad-exit-annotation) - `PYI041`: [`redundant-numeric-union`](https://beta.ruff.rs/docs/rules/redundant-numeric-union) - `PYI042`: [`snake-case-type-alias`](https://beta.ruff.rs/docs/rules/snake-case-type-alias) - `PYI043`: [`t-suffixed-type-alias`](https://beta.ruff.rs/docs/rules/t-suffixed-type-alias) - `PYI045`: [`iter-method-return-iterable`](https://beta.ruff.rs/docs/rules/iter-method-return-iterable) - `PYI046`: [`unused-private-protocol`](https://beta.ruff.rs/docs/rules/unused-private-protocol) - `PYI047`: [`unused-private-type-alias`](https://beta.ruff.rs/docs/rules/unused-private-type-alias) - `PYI049`: [`unused-private-typed-dict`](https://beta.ruff.rs/docs/rules/unused-private-typed-dict) - `PYI050`: [`no-return-argument-annotation-in-stub`](https://beta.ruff.rs/docs/rules/no-return-argument-annotation-in-stub) (Python ≥ 3.11) - `PYI051`: [`redundant-literal-union`](https://beta.ruff.rs/docs/rules/redundant-literal-union) - `PYI056`: [`unsupported-method-call-on-all`](https://beta.ruff.rs/docs/rules/unsupported-method-call-on-all) - \[`flake8-pyi`] `PYI027` is being replaced by `PYI022` / `UP035` by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#6354 - \[`pydocstyle`] `D103`: Don't require docstrings in `.pyi` files by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6239 - \[`pydocstyle`] `D203`: Ignore same-line docstrings for lines-before and lines-after rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6344 - \[`pylint`] `PLE0605`: Allow generic tuple and list calls in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6247 - \[`pylint`] `PLR0124`: Add detection of comparisons with built-in calls by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6324 - \[`pyupgrade`] `UP032`: Add support for `await` expressions in f-strings by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6304 - \[`pyupgrade`] `UP032`: Add support for implicitly concatenated strings by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6263 - \[`pyupgrade`] `UP032`: Add support for repeated format fields by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6266 - \[`ruff`] `RUF012`: Permit `ClassVar` and `Final` without subscript by [@bluetech](https://togithub.com/bluetech) in [astral-sh/ruff#6273 ##### Bug Fixes - \[`flake8-bugbear`] `B006`: Respect `typing_extensions` imports of `Annotated` by [@PIG208](https://togithub.com/PIG208) in [astral-sh/ruff#6361 - \[`flake8-pyi`] `PYI019`: Fix panic with positional-only arguments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6350 - \[`flake8-use-pathlib`] Avoid raising `PTH206` with `maxsplit` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6283 - \[`flake8`] `F841`: Update autofix to not remove Jupyer magic expressions by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#6141 - \[`pycodestyle`] `E721`: Include comparisons to builtin types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6325 - \[`pycodestyle`] `E721`: Match left-hand side `types()` call in `types-comparison` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6326 - \[`pyupgrade`] `UP031`: Avoid auto-fixing if there are comments within the right-hand side by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6364 - \[`pyupgrade`] `UP032`: Avoid auto-fixing if comments are present around format call arguments by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6342 - \[`pyupgrade`] `UP032`: Improve invalid expression check by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6308 - Avoid attempting to fix `.format(...)` calls with too-few-arguments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6401 - Fix bug where `.gitignore` files in parent directories were incorrectly used by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6368 - Fix duplicate violations raised on nested bitwise or `Union` expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6399 ##### Playground - Add a simple tooltip to the sidebar by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6295 - Add an icon for FIR by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6292 - Increase icon opacity on-hover by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6291 - Tweak background on theme button by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6290 ##### Other Changes - Improve handling of violations around Jupyter magic expressions by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5552 - Reduce memory usage by boxing type params and arguments fields on the class definition node by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6275 - Upgrade Rust to 1.71 by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6323 #### New Contributors - [@silvanocerza](https://togithub.com/silvanocerza) made their first contribution in [astral-sh/ruff#6171 - [@PIG208](https://togithub.com/PIG208) made their first contribution in [astral-sh/ruff#6361 **Full Changelog**: astral-sh/ruff@v0.0.282...v0.0.283 ### [`v0.0.282`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.282) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.281...v0.0.282)  #### What's Changed ##### Bug Fixes - Reset model state when exiting deferred visitors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6208 - Skip trivia when searching for named exception by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6218 - Avoid PERF401 false positive on list access in loop by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6220 - Avoid detecting continuations at non-start-of-line by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6219 - Revert "Expand scope of `quoted-annotation` rule ([#5766](https://togithub.com/astral-sh/ruff/issues/5766))" by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6237 #### New Contributors - [@klistwan](https://togithub.com/klistwan) made their first contribution in [astral-sh/ruff#6146 **Full Changelog**: astral-sh/ruff@v0.0.281...v0.0.282 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ixm-one/pytest-cmake-presets).  Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.282` -> `==0.0.284` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.284?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.284?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.282/0.0.284?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.282/0.0.284?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.284`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.284) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.283...v0.0.284) #### What's Changed This release fixes a few bugs, notably the previous release announced a breaking change where the default target Python version changed from 3.10 to 3.8 but the change was not applied. Thanks to [@rco-ableton](https://togithub.com/rco-ableton) for fixing this in [astral-sh/ruff#6444 ##### Bug Fixes - Do not trigger `S108` if path is inside `tempfile.*` call by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#6416 - Do not allow on zero tab width by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#6429 - Fix false-positive in submodule resolution by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6435 #### New Contributors - [@rco-ableton](https://togithub.com/rco-ableton) made their first contribution in [astral-sh/ruff#6444 **Full Changelog**: astral-sh/ruff@v0.0.283...v0.0.284 ### [`v0.0.283`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.283) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.282...v0.0.283)  #### What's Changed ##### Breaking Changes - Assume Python 3.8 instead of 3.10 for target version by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6397 ##### Rules - \[`flake8-pyi`] `PYI019`: Detects if a type variable is used instead of `Self` in return annotations by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#6204 - \[`flake8-pyi`] `PYI051`: Detects unions of `Literal` types by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#6215 - \[`flake8-pyi`] `PYI055`: Detects unions of `type`s by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#6316 - \[`pylint`] `E1300`: Detects invalid string format characters by [@silvanocerza](https://togithub.com/silvanocerza) in [astral-sh/ruff#6171 - \[`pyupgrade`] `UP040`: Upgrades type alias annotations to use PEP-695 syntax by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6289 ##### Rule Changes - \[`flake8-boolean-trap`] `FBT003`: Add `is_` and `is_not` to excluded functions by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6307 - \[`flake8-logging-format`] Allow capitalized names for logger candidate heuristic match by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6356 - \[`flake8-pyi`] Applicable rules are now checked non-stub code by [@andersk](https://togithub.com/andersk) in [astral-sh/ruff#6297 - `PYI013`: [`ellipsis-in-non-empty-class-body`](https://beta.ruff.rs/docs/rules/ellipsis-in-non-empty-class-body) - `PYI016`: [`duplicate-union-member`](https://beta.ruff.rs/docs/rules/duplicate-union-member) - `PYI018`: [`unused-private-type-var`](https://beta.ruff.rs/docs/rules/unused-private-type-var) - `PYI019`: [`custom-type-var-return-type`](https://beta.ruff.rs/docs/rules/custom-type-var-return-type) - `PYI024`: [`collections-named-tuple`](https://beta.ruff.rs/docs/rules/collections-named-tuple) - `PYI025`: [`unaliased-collections-abc-set-import`](https://beta.ruff.rs/docs/rules/unaliased-collections-abc-set-import) - `PYI030`: [`unnecessary-literal-union`](https://beta.ruff.rs/docs/rules/unnecessary-literal-union) - `PYI032`: [`any-eq-ne-annotation`](https://beta.ruff.rs/docs/rules/any-eq-ne-annotation) - `PYI034`: [`non-self-return-type`](https://beta.ruff.rs/docs/rules/non-self-return-type) - `PYI036`: [`bad-exit-annotation`](https://beta.ruff.rs/docs/rules/bad-exit-annotation) - `PYI041`: [`redundant-numeric-union`](https://beta.ruff.rs/docs/rules/redundant-numeric-union) - `PYI042`: [`snake-case-type-alias`](https://beta.ruff.rs/docs/rules/snake-case-type-alias) - `PYI043`: [`t-suffixed-type-alias`](https://beta.ruff.rs/docs/rules/t-suffixed-type-alias) - `PYI045`: [`iter-method-return-iterable`](https://beta.ruff.rs/docs/rules/iter-method-return-iterable) - `PYI046`: [`unused-private-protocol`](https://beta.ruff.rs/docs/rules/unused-private-protocol) - `PYI047`: [`unused-private-type-alias`](https://beta.ruff.rs/docs/rules/unused-private-type-alias) - `PYI049`: [`unused-private-typed-dict`](https://beta.ruff.rs/docs/rules/unused-private-typed-dict) - `PYI050`: [`no-return-argument-annotation-in-stub`](https://beta.ruff.rs/docs/rules/no-return-argument-annotation-in-stub) (Python ≥ 3.11) - `PYI051`: [`redundant-literal-union`](https://beta.ruff.rs/docs/rules/redundant-literal-union) - `PYI056`: [`unsupported-method-call-on-all`](https://beta.ruff.rs/docs/rules/unsupported-method-call-on-all) - \[`flake8-pyi`] `PYI027` is being replaced by `PYI022` / `UP035` by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#6354 - \[`pydocstyle`] `D103`: Don't require docstrings in `.pyi` files by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6239 - \[`pydocstyle`] `D203`: Ignore same-line docstrings for lines-before and lines-after rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6344 - \[`pylint`] `PLE0605`: Allow generic tuple and list calls in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6247 - \[`pylint`] `PLR0124`: Add detection of comparisons with built-in calls by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6324 - \[`pyupgrade`] `UP032`: Add support for `await` expressions in f-strings by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6304 - \[`pyupgrade`] `UP032`: Add support for implicitly concatenated strings by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6263 - \[`pyupgrade`] `UP032`: Add support for repeated format fields by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6266 - \[`ruff`] `RUF012`: Permit `ClassVar` and `Final` without subscript by [@bluetech](https://togithub.com/bluetech) in [astral-sh/ruff#6273 ##### Bug Fixes - \[`flake8-bugbear`] `B006`: Respect `typing_extensions` imports of `Annotated` by [@PIG208](https://togithub.com/PIG208) in [astral-sh/ruff#6361 - \[`flake8-pyi`] `PYI019`: Fix panic with positional-only arguments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6350 - \[`flake8-use-pathlib`] Avoid raising `PTH206` with `maxsplit` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6283 - \[`flake8`] `F841`: Update autofix to not remove Jupyer magic expressions by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#6141 - \[`pycodestyle`] `E721`: Include comparisons to builtin types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6325 - \[`pycodestyle`] `E721`: Match left-hand side `types()` call in `types-comparison` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6326 - \[`pyupgrade`] `UP031`: Avoid auto-fixing if there are comments within the right-hand side by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6364 - \[`pyupgrade`] `UP032`: Avoid auto-fixing if comments are present around format call arguments by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6342 - \[`pyupgrade`] `UP032`: Improve invalid expression check by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6308 - Avoid attempting to fix `.format(...)` calls with too-few-arguments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6401 - Fix bug where `.gitignore` files in parent directories were incorrectly used by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6368 - Fix duplicate violations raised on nested bitwise or `Union` expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6399 ##### Playground - Add a simple tooltip to the sidebar by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6295 - Add an icon for FIR by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6292 - Increase icon opacity on-hover by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6291 - Tweak background on theme button by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6290 ##### Other Changes - Improve handling of violations around Jupyter magic expressions by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5552 - Reduce memory usage by boxing type params and arguments fields on the class definition node by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6275 - Upgrade Rust to 1.71 by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6323 #### New Contributors - [@silvanocerza](https://togithub.com/silvanocerza) made their first contribution in [astral-sh/ruff#6171 - [@PIG208](https://togithub.com/PIG208) made their first contribution in [astral-sh/ruff#6361 **Full Changelog**: astral-sh/ruff@v0.0.282...v0.0.283 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.282` -> `==0.0.284` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.284?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.284?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.282/0.0.284?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.282/0.0.284?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.284`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.284) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.283...v0.0.284) #### What's Changed This release fixes a few bugs, notably the previous release announced a breaking change where the default target Python version changed from 3.10 to 3.8 but the change was not applied. Thanks to [@rco-ableton](https://togithub.com/rco-ableton) for fixing this in [astral-sh/ruff#6444 ##### Bug Fixes - Do not trigger `S108` if path is inside `tempfile.*` call by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#6416 - Do not allow on zero tab width by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#6429 - Fix false-positive in submodule resolution by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6435 #### New Contributors - [@rco-ableton](https://togithub.com/rco-ableton) made their first contribution in [astral-sh/ruff#6444 **Full Changelog**: astral-sh/ruff@v0.0.283...v0.0.284 ### [`v0.0.283`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.283) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.282...v0.0.283)  #### What's Changed ##### Breaking Changes - Assume Python 3.8 instead of 3.10 for target version by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6397 ##### Rules - \[`flake8-pyi`] `PYI019`: Detects if a type variable is used instead of `Self` in return annotations by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#6204 - \[`flake8-pyi`] `PYI051`: Detects unions of `Literal` types by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#6215 - \[`flake8-pyi`] `PYI055`: Detects unions of `type`s by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#6316 - \[`pylint`] `E1300`: Detects invalid string format characters by [@silvanocerza](https://togithub.com/silvanocerza) in [astral-sh/ruff#6171 - \[`pyupgrade`] `UP040`: Upgrades type alias annotations to use PEP-695 syntax by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6289 ##### Rule Changes - \[`flake8-boolean-trap`] `FBT003`: Add `is_` and `is_not` to excluded functions by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6307 - \[`flake8-logging-format`] Allow capitalized names for logger candidate heuristic match by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6356 - \[`flake8-pyi`] Applicable rules are now checked non-stub code by [@andersk](https://togithub.com/andersk) in [astral-sh/ruff#6297 - `PYI013`: [`ellipsis-in-non-empty-class-body`](https://beta.ruff.rs/docs/rules/ellipsis-in-non-empty-class-body) - `PYI016`: [`duplicate-union-member`](https://beta.ruff.rs/docs/rules/duplicate-union-member) - `PYI018`: [`unused-private-type-var`](https://beta.ruff.rs/docs/rules/unused-private-type-var) - `PYI019`: [`custom-type-var-return-type`](https://beta.ruff.rs/docs/rules/custom-type-var-return-type) - `PYI024`: [`collections-named-tuple`](https://beta.ruff.rs/docs/rules/collections-named-tuple) - `PYI025`: [`unaliased-collections-abc-set-import`](https://beta.ruff.rs/docs/rules/unaliased-collections-abc-set-import) - `PYI030`: [`unnecessary-literal-union`](https://beta.ruff.rs/docs/rules/unnecessary-literal-union) - `PYI032`: [`any-eq-ne-annotation`](https://beta.ruff.rs/docs/rules/any-eq-ne-annotation) - `PYI034`: [`non-self-return-type`](https://beta.ruff.rs/docs/rules/non-self-return-type) - `PYI036`: [`bad-exit-annotation`](https://beta.ruff.rs/docs/rules/bad-exit-annotation) - `PYI041`: [`redundant-numeric-union`](https://beta.ruff.rs/docs/rules/redundant-numeric-union) - `PYI042`: [`snake-case-type-alias`](https://beta.ruff.rs/docs/rules/snake-case-type-alias) - `PYI043`: [`t-suffixed-type-alias`](https://beta.ruff.rs/docs/rules/t-suffixed-type-alias) - `PYI045`: [`iter-method-return-iterable`](https://beta.ruff.rs/docs/rules/iter-method-return-iterable) - `PYI046`: [`unused-private-protocol`](https://beta.ruff.rs/docs/rules/unused-private-protocol) - `PYI047`: [`unused-private-type-alias`](https://beta.ruff.rs/docs/rules/unused-private-type-alias) - `PYI049`: [`unused-private-typed-dict`](https://beta.ruff.rs/docs/rules/unused-private-typed-dict) - `PYI050`: [`no-return-argument-annotation-in-stub`](https://beta.ruff.rs/docs/rules/no-return-argument-annotation-in-stub) (Python ≥ 3.11) - `PYI051`: [`redundant-literal-union`](https://beta.ruff.rs/docs/rules/redundant-literal-union) - `PYI056`: [`unsupported-method-call-on-all`](https://beta.ruff.rs/docs/rules/unsupported-method-call-on-all) - \[`flake8-pyi`] `PYI027` is being replaced by `PYI022` / `UP035` by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#6354 - \[`pydocstyle`] `D103`: Don't require docstrings in `.pyi` files by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6239 - \[`pydocstyle`] `D203`: Ignore same-line docstrings for lines-before and lines-after rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6344 - \[`pylint`] `PLE0605`: Allow generic tuple and list calls in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6247 - \[`pylint`] `PLR0124`: Add detection of comparisons with built-in calls by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6324 - \[`pyupgrade`] `UP032`: Add support for `await` expressions in f-strings by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6304 - \[`pyupgrade`] `UP032`: Add support for implicitly concatenated strings by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6263 - \[`pyupgrade`] `UP032`: Add support for repeated format fields by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6266 - \[`ruff`] `RUF012`: Permit `ClassVar` and `Final` without subscript by [@bluetech](https://togithub.com/bluetech) in [astral-sh/ruff#6273 ##### Bug Fixes - \[`flake8-bugbear`] `B006`: Respect `typing_extensions` imports of `Annotated` by [@PIG208](https://togithub.com/PIG208) in [astral-sh/ruff#6361 - \[`flake8-pyi`] `PYI019`: Fix panic with positional-only arguments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6350 - \[`flake8-use-pathlib`] Avoid raising `PTH206` with `maxsplit` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6283 - \[`flake8`] `F841`: Update autofix to not remove Jupyer magic expressions by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#6141 - \[`pycodestyle`] `E721`: Include comparisons to builtin types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6325 - \[`pycodestyle`] `E721`: Match left-hand side `types()` call in `types-comparison` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6326 - \[`pyupgrade`] `UP031`: Avoid auto-fixing if there are comments within the right-hand side by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6364 - \[`pyupgrade`] `UP032`: Avoid auto-fixing if comments are present around format call arguments by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6342 - \[`pyupgrade`] `UP032`: Improve invalid expression check by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#6308 - Avoid attempting to fix `.format(...)` calls with too-few-arguments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6401 - Fix bug where `.gitignore` files in parent directories were incorrectly used by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6368 - Fix duplicate violations raised on nested bitwise or `Union` expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6399 ##### Playground - Add a simple tooltip to the sidebar by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6295 - Add an icon for FIR by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6292 - Increase icon opacity on-hover by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6291 - Tweak background on theme button by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6290 ##### Other Changes - Improve handling of violations around Jupyter magic expressions by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5552 - Reduce memory usage by boxing type params and arguments fields on the class definition node by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#6275 - Upgrade Rust to 1.71 by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#6323 #### New Contributors - [@silvanocerza](https://togithub.com/silvanocerza) made their first contribution in [astral-sh/ruff#6171 - [@PIG208](https://togithub.com/PIG208) made their first contribution in [astral-sh/ruff#6361 **Full Changelog**: astral-sh/ruff@v0.0.282...v0.0.283 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

## Summary In astral-sh#6397, the documentation was updated stating that the default target-version is now "py38", but the actual default value wasn't updated and remained py310. This commit updates the default value to match what the documentation says.

@rco-ableton

## What's Changed This release fixes a few bugs, notably the previous release announced a breaking change where the default target Python version changed from 3.10 to 3.8 but it was not applied. Thanks to @rco-ableton for fixing this in astral-sh#6444 ### Bug Fixes * Do not trigger `S108` if path is inside `tempfile.*` call by @dhruvmanila in astral-sh#6416 * Do not allow on zero tab width by @tjkuson in astral-sh#6429 * Fix false-positive in submodule resolution by @charliermarsh in astral-sh#6435 ## New Contributors * @rco-ableton made their first contribution in astral-sh#6444 **Full Changelog**: astral-sh/ruff@v0.0.283...v0.0.284

Set default version to py38

5b20ee2

In astral-sh#6397, the documentation was updated stating that the default target-version is now "py38", but the actual default value wasn't updated and remained py310. This commit updates the default value to match what the documentation says.

Set to 3.8

04e04d4

charliermarsh requested review from zanieb and removed request for zanieb August 9, 2023 11:41

Update tests

e359ebd

charliermarsh enabled auto-merge (squash) August 9, 2023 11:57

charliermarsh disabled auto-merge August 9, 2023 11:59

Update snapshot

5180f0c

charliermarsh enabled auto-merge (squash) August 9, 2023 12:01

charliermarsh reviewed Aug 9, 2023

View reviewed changes

charliermarsh mentioned this pull request Aug 9, 2023

Set a default on PythonVersion #6446

Merged

charliermarsh merged commit eaada03 into astral-sh:main Aug 9, 2023
16 checks passed

rco-ableton deleted the actually-set-default-target branch August 9, 2023 13:25

zanieb mentioned this pull request Aug 9, 2023

Bump version to 0.0.284 #6453

Merged

chenrui333 mentioned this pull request Aug 9, 2023

ruff 0.0.284 Homebrew/homebrew-core#139124

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set default version to py38 #6444

Set default version to py38 #6444

rco-ableton commented Aug 9, 2023

github-actions bot commented Aug 9, 2023 •

edited

charliermarsh commented Aug 9, 2023

charliermarsh commented Aug 9, 2023

charliermarsh Aug 9, 2023

zanieb Aug 9, 2023

charliermarsh Aug 9, 2023

rco-ableton Aug 9, 2023

zanieb commented Aug 9, 2023

Set default version to py38 #6444

Set default version to py38 #6444

Conversation

rco-ableton commented Aug 9, 2023

Summary

Test Plan

github-actions bot commented Aug 9, 2023 • edited

PR Check Results

Ecosystem

Benchmark

Linux

Windows

charliermarsh commented Aug 9, 2023

charliermarsh commented Aug 9, 2023

charliermarsh Aug 9, 2023

Choose a reason for hiding this comment

zanieb Aug 9, 2023

Choose a reason for hiding this comment

charliermarsh Aug 9, 2023

Choose a reason for hiding this comment

rco-ableton Aug 9, 2023

Choose a reason for hiding this comment

zanieb commented Aug 9, 2023

github-actions bot commented Aug 9, 2023 •

edited