Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint pyproject.toml #4496

Merged
merged 12 commits into from May 25, 2023
Merged

Lint pyproject.toml #4496

merged 12 commits into from May 25, 2023

Commits on May 24, 2023

  1. Lint pyproject.toml

    This adds a new rule `InvalidPyprojectToml` that lints pyproject.toml by checking if https://github.com/PyO3/pyproject-toml-rs can parse it. This means the linting is currently very basic, e.g. we don't check whether the name is actually a valid python project name or appropriately normalized. It does catch errors e.g. with invalid dependency requirements or problems withs the license specifications. It is open to be extended in the future (validate name, SPDX expressions, classifiers, ...), either in ruff or in pyproject-toml-rs.
    
    TODOs:
    
     - [ ] Why does `FilePattern::Builtin("pyproject.toml")` alone not work? I've added `*.toml` for now to test but this should be changed before merging (help wanted)
     - [ ] Run this over the ecosystem CI dataset
    konstin committed May 24, 2023
    Configuration menu
    Copy the full SHA
    f7282c5 View commit details
    Browse the repository at this point in the history
  2. Update schema

    konstin committed May 24, 2023
    Configuration menu
    Copy the full SHA
    1653ece View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    825da4e View commit details
    Browse the repository at this point in the history
  4. Fix typo in fixture

    konstin committed May 24, 2023
    Configuration menu
    Copy the full SHA
    d4b2e5a View commit details
    Browse the repository at this point in the history
  5. Fix default inclusion pattern

    konstin committed May 24, 2023
    Configuration menu
    Copy the full SHA
    cb6e79c View commit details
    Browse the repository at this point in the history
  6. Update crates/ruff_cli/src/diagnostics.rs

    Co-authored-by: Micha Reiser <micha@reiser.io>
    konstin and MichaReiser committed May 24, 2023
    Configuration menu
    Copy the full SHA
    96abd71 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    63118fd View commit details
    Browse the repository at this point in the history
  8. Link missing span issue

    konstin committed May 24, 2023
    Configuration menu
    Copy the full SHA
    1d67d96 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6ec6e03 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    477cf65 View commit details
    Browse the repository at this point in the history
  11. Make build system optional

    konstin committed May 24, 2023
    Configuration menu
    Copy the full SHA
    1a05901 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. cargo clippy

    konstin committed May 25, 2023
    Configuration menu
    Copy the full SHA
    5ae314d View commit details
    Browse the repository at this point in the history