New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint pyproject.toml #4496
Merged
Merged
Lint pyproject.toml #4496
Commits on May 24, 2023
-
This adds a new rule `InvalidPyprojectToml` that lints pyproject.toml by checking if https://github.com/PyO3/pyproject-toml-rs can parse it. This means the linting is currently very basic, e.g. we don't check whether the name is actually a valid python project name or appropriately normalized. It does catch errors e.g. with invalid dependency requirements or problems withs the license specifications. It is open to be extended in the future (validate name, SPDX expressions, classifiers, ...), either in ruff or in pyproject-toml-rs. TODOs: - [ ] Why does `FilePattern::Builtin("pyproject.toml")` alone not work? I've added `*.toml` for now to test but this should be changed before merging (help wanted) - [ ] Run this over the ecosystem CI dataset
Configuration menu - View commit details
-
Copy full SHA for f7282c5 - Browse repository at this point
Copy the full SHA f7282c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1653ece - Browse repository at this point
Copy the full SHA 1653eceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 825da4e - Browse repository at this point
Copy the full SHA 825da4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4b2e5a - Browse repository at this point
Copy the full SHA d4b2e5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb6e79c - Browse repository at this point
Copy the full SHA cb6e79cView commit details -
Update crates/ruff_cli/src/diagnostics.rs
Co-authored-by: Micha Reiser <micha@reiser.io>
Configuration menu - View commit details
-
Copy full SHA for 96abd71 - Browse repository at this point
Copy the full SHA 96abd71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63118fd - Browse repository at this point
Copy the full SHA 63118fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d67d96 - Browse repository at this point
Copy the full SHA 1d67d96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ec6e03 - Browse repository at this point
Copy the full SHA 6ec6e03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 477cf65 - Browse repository at this point
Copy the full SHA 477cf65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a05901 - Browse repository at this point
Copy the full SHA 1a05901View commit details
Commits on May 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5ae314d - Browse repository at this point
Copy the full SHA 5ae314dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.