Consider same-site fixes to be overlapping

crates/ruff/src/autofix/mod.rs

@@ -28,7 +28,7 @@ fn apply_fixes<'a>(
     locator: &'a Locator<'a>,
 ) -> (String, FixTable) {
     let mut output = String::with_capacity(locator.len());
-    let mut last_pos: Location = Location::new(1, 0);
+    let mut last_pos: Option<Location> = None;
     let mut applied: BTreeSet<&Fix> = BTreeSet::default();
     let mut fixed = FxHashMap::default();
 
@@ -50,25 +50,25 @@ fn apply_fixes<'a>(
 
         // Best-effort approach: if this fix overlaps with a fix we've already applied,
         // skip it.
-        if last_pos > fix.location {
+        if last_pos.map_or(false, |last_pos| last_pos >= fix.location) {
             continue;
         }
 
         // Add all contents from `last_pos` to `fix.location`.
-        let slice = locator.slice(Range::new(last_pos, fix.location));
+        let slice = locator.slice(Range::new(last_pos.unwrap_or_default(), fix.location));
         output.push_str(slice);
 
         // Add the patch itself.
         output.push_str(&fix.content);
 
         // Track that the fix was applied.
-        last_pos = fix.end_location;
+        last_pos = Some(fix.end_location);
         applied.insert(fix);
         *fixed.entry(rule).or_default() += 1;
     }
 
     // Add the remaining content.
-    let slice = locator.skip(last_pos);
+    let slice = locator.skip(last_pos.unwrap_or_default());
     output.push_str(slice);
 
     (output, fixed)
@@ -194,29 +194,29 @@ class A:
     fn apply_two_removals() {
         let locator = Locator::new(
             r#"
-class A(object, object):
+class A(object, object, object):
     ...
 "#
             .trim(),
         );
         let diagnostics = create_diagnostics([
             Fix {
                 content: String::new(),
-                location: Location::new(1, 7),
+                location: Location::new(1, 8),
                 end_location: Location::new(1, 16),
             },
             Fix {
                 content: String::new(),
-                location: Location::new(1, 16),
-                end_location: Location::new(1, 23),
+                location: Location::new(1, 22),
+                end_location: Location::new(1, 30),
             },
         ]);
         let (contents, fixed) = apply_fixes(diagnostics.iter(), &locator);
 
         assert_eq!(
             contents,
             r#"
-class A:
+class A(object):
     ...
 "#
             .trim()

crates/ruff/src/rules/flake8_return/rules.rs

@@ -219,8 +219,6 @@ fn implicit_return(checker: &mut Checker, stmt: &Stmt) {
                         content.push_str(checker.stylist.line_ending().as_str());
                         content.push_str(indent);
                         content.push_str("return None");
-                        // This is the last statement in the function. So it has to be followed by
-                        // a newline, or comments, or nothing.
                         diagnostic.amend(Fix::insertion(
                             content,
                             end_of_statement(stmt, checker.locator),