Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-executables] Allow uv run in shebang line for shebang-missing-python (EXE003) #16849

Merged
merged 4 commits into from
Mar 19, 2025

Conversation

dylwil3
Copy link
Collaborator

@dylwil3 dylwil3 commented Mar 19, 2025

Skip the lint for shebang-missing-python (EXE003) if we find uv run on the shebang line.

Closes #13021

@dylwil3 dylwil3 added the rule Implementing or modifying a lint rule label Mar 19, 2025
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dylwil3 dylwil3 merged commit 98fdc0e into astral-sh:main Mar 19, 2025
22 checks passed
@andrei-korshikov
Copy link

I believe this line should be changed too:

"Shebang should contain `python`".to_string()

E.g.

"Shebang should contain `python`, `pytest`, or `uv run`".to_string()

dylwil3 added a commit that referenced this pull request Mar 19, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ang-missing-python` (`EXE003`) (#16855)

Followup to #16849 per
#16849 (comment)
@dylwil3 dylwil3 deleted the shebang-uv branch March 19, 2025 18:12
dcreager added a commit that referenced this pull request Mar 21, 2025
* main: (26 commits)
  Use the common `OperatorPrecedence` for the parser (#16747)
  [red-knot] Check subtype relation between callable types (#16804)
  [red-knot] Check whether two callable types are equivalent (#16698)
  [red-knot] Ban most `Type::Instance` types in type expressions (#16872)
  Special-case value-expression inference of special form subscriptions (#16877)
  [syntax-errors] Fix star annotation before Python 3.11 (#16878)
  Recognize `SyntaxError:` as an error code for ecosystem checks (#16879)
  [red-knot] add test cases result in false positive errors (#16856)
  Bump 0.11.1 (#16871)
  Allow discovery of venv in VIRTUAL_ENV env variable (#16853)
  Split git pathspecs in change determination onto separate lines (#16869)
  Use the correct base commit for change determination (#16857)
  Separate `BitXorOr` into `BitXor` and `BitOr` precedence (#16844)
  Server: Allow `FixAll` action in presence of version-specific syntax errors (#16848)
  [`refurb`] Fix starred expressions fix (`FURB161`) (#16550)
  [`flake8-executable`] Add pytest and uv run to help message for `shebang-missing-python` (`EXE003`) (#16855)
  Show more precise messages in invalid type expressions (#16850)
  [`flake8-executables`] Allow `uv run` in shebang line for `shebang-missing-python` (`EXE003`) (#16849)
  Add `--exit-non-zero-on-format` (#16009)
  [red-knot] Ban list literals in most contexts in type expressions (#16847)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EXE003 and uv run?
3 participants