[ruff] Fix --statistics reporting for unsafe fixes
#16756
Merged
+75
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes astral-sh#16751 Previously, unsafe fixes were counted as "fixable" in `Printer::write_statistics`, in contrast to the behaviour in `Printer::write_once`. This changes the behaviour to align with `write_once`, including them only if `--unsafe-fixes` is set. We now also reuse `Printer::write_summary` to avoid duplicating the logic for whether or not to report if there are hidden fixes.
|
MichaReiser
approved these changes
Mar 18, 2025
MichaReiser
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16751
Summary
Previously, unsafe fixes were counted as "fixable" in
Printer::write_statistics, in contrast to the behaviour inPrinter::write_once. This changes the behaviour to align withwrite_once, including them only if--unsafe-fixesis set.We now also reuse
Printer::write_summaryto avoid duplicating the logic for whether or not to report if there are hidden fixes.Test Plan
Existing tests modified to use an unsafe-fixable rule, and new ones added to cover the case with
--unsafe-fixes