Ignore non-file workspace URL #12725
Merged
+22
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dhruvmanila
force-pushed
the
dhruv/ignore-non-workspace-url
branch
from
bed704f to
5cbbbf6
Compare
MichaReiser
approved these changes
Aug 7, 2024
dhruvmanila
added a commit
that referenced
this pull request
Aug 7, 2024
## Summary Follow-up from #12725, this is just a small refactor to use a wrapper struct instead of type alias for workspace settings index. This avoids the need to have the `register_workspace_settings` as a static method on `Index` and instead is a method on the new struct itself.
dylwil3
pushed a commit
to dylwil3/ruff
that referenced
this pull request
Aug 7, 2024
## Summary This PR updates the server to ignore non-file workspace URL. This is to avoid crashing the server if the URL scheme is not "file". We'd still raise an error if the URL to file path conversion fails. Also, as per the docs of [`to_file_path`](https://docs.rs/url/2.5.2/url/struct.Url.html#method.to_file_path): > Note: This does not actually check the URL’s scheme, and may give nonsensical results for other schemes. It is the user’s responsibility to check the URL’s scheme before calling this. resolves: astral-sh#12660 ## Test Plan I'm not sure how to test this locally but the change is small enough to validate on its own.
dylwil3
pushed a commit
to dylwil3/ruff
that referenced
this pull request
Aug 7, 2024
…-sh#12726) ## Summary Follow-up from astral-sh#12725, this is just a small refactor to use a wrapper struct instead of type alias for workspace settings index. This avoids the need to have the `register_workspace_settings` as a static method on `Index` and instead is a method on the new struct itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the server to ignore non-file workspace URL.
This is to avoid crashing the server if the URL scheme is not "file". We'd still raise an error if the URL to file path conversion fails.
Also, as per the docs of
to_file_path:resolves: #12660
Test Plan
I'm not sure how to test this locally but the change is small enough to validate on its own.