Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix division by zero error in ecosystem check #11469

Merged
merged 1 commit into from
May 19, 2024
Merged

Fix division by zero error in ecosystem check #11469

merged 1 commit into from
May 19, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented May 19, 2024

@zanieb zanieb added the internal An internal refactor or improvement label May 19, 2024
Copy link

codspeed-hq bot commented May 19, 2024

CodSpeed Performance Report

Merging #11469 will not alter performance

Comparing zb/eco-fix (4f29594) with main (d9ec3d5)

Summary

✅ 30 untouched benchmarks

@zanieb zanieb changed the base branch from charlie/eco to main May 19, 2024 04:04
Copy link
Contributor

github-actions bot commented May 19, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 1 projects; 49 projects unchanged)

python-poetry/poetry (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ tests/repositories/test_legacy_repository.py:386:39: E999 SyntaxError: Got unexpected string

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
E999 1 1 0 0 0

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@zanieb
Copy link
Member Author

zanieb commented May 19, 2024

Looks like this is actually a bug in reporting clone failures per e6ba39e fixing.

Regardless this seems like an improvement for now?

@zanieb zanieb merged commit 46fcd19 into main May 19, 2024
19 checks passed
@zanieb zanieb deleted the zb/eco-fix branch May 19, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants