Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ruff] fix async comprehension false positive (RUF029) #11070

Merged
merged 1 commit into from
Apr 21, 2024
Merged

[ruff] fix async comprehension false positive (RUF029) #11070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/ruff_linter/resources/test/fixtures/ruff/RUF029.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,7 @@ async def foo(self):
def foo():
async def fail_4c(): # RUF029: the /inner/ function does not await
pass


async def test():
return [check async for check in async_func()]
5 changes: 5 additions & 0 deletions crates/ruff_linter/src/rules/ruff/rules/unused_async.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ impl<'a> preorder::PreorderVisitor<'a> for AsyncExprVisitor {
_ => preorder::walk_stmt(self, stmt),
}
}
fn visit_comprehension(&mut self, comprehension: &'a ast::Comprehension) {
if comprehension.is_async {
self.found_await_or_async = true;
}
}
}

/// Very nearly `crate::node::StmtFunctionDef.visit_preorder`, except it is specialized and,
Expand Down