Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect per-file-ignores for RUF100 with no other diagnostics #11058

Merged
merged 1 commit into from Apr 20, 2024
Merged

Respect per-file-ignores for RUF100 with no other diagnostics #11058

merged 1 commit into from Apr 20, 2024

Conversation

charliermarsh
Copy link
Member

Summary

The existing test didn't cover the case in which there are no other diagnostics in the file.

Closes #10906.

@charliermarsh charliermarsh added bug Something isn't working suppression Related to supression of violations e.g. noqa labels Apr 20, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) April 20, 2024 15:26
@charliermarsh charliermarsh merged commit d544199 into main Apr 20, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/per branch April 20, 2024 15:33
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@BrewTestBot BrewTestBot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working suppression Related to supression of violations e.g. noqa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUF100 error despite listed in per-file-ignores
1 participant
@charliermarsh