Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pylint] Implement invalid-hash-returned (PLE0309) #10961

Merged

Conversation

tibor-reiss
Copy link
Contributor

@tibor-reiss tibor-reiss commented Apr 15, 2024

Add pylint rule invalid-hash-returned (PLE0309)

See #970 for rules

Test Plan: cargo test

TBD: from the description: "Strictly speaking bool is a subclass of int, thus returning True/False is valid. To be consistent with other rules (e.g. PLE0305 invalid-index-returned), ruff will raise, compared to pylint which will not raise."

Copy link

codspeed-hq bot commented Apr 15, 2024

CodSpeed Performance Report

Merging #10961 will not alter performance

Comparing tibor-reiss:add-E0309-invalid-hash-returned (b5d22ac) with main (5d3c9f2)

Summary

✅ 30 untouched benchmarks

Copy link
Contributor

github-actions bot commented Apr 15, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@tibor-reiss tibor-reiss force-pushed the add-E0309-invalid-hash-returned branch from 81b4c26 to 4118cac Compare April 16, 2024 18:07
@tibor-reiss tibor-reiss force-pushed the add-E0309-invalid-hash-returned branch from 40e773c to 99e7357 Compare April 18, 2024 18:07
@tibor-reiss tibor-reiss force-pushed the add-E0309-invalid-hash-returned branch from 99e7357 to 4875d68 Compare April 18, 2024 18:23
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh changed the title [pylint] Implement invalid-hash-returned (PLE0309) [pylint] Implement invalid-hash-returned (PLE0309) Apr 19, 2024
@charliermarsh charliermarsh added rule Implementing or modifying a lint rule preview Related to preview mode features labels Apr 19, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) April 19, 2024 03:27
@charliermarsh charliermarsh merged commit adf63d9 into astral-sh:main Apr 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants