Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-comprehensions] Handled special case for C401 which also matches C416 #10596

Merged

Conversation

boolean-light
Copy link
Contributor

Summary

Similar to #10419, there was a case where there is a collision of C401 and C416 (as discussed in #10101).
Fixed this by implementing short-circuit for the comprehension of the form {x for x in foo}.

Test Plan

Extended C401.py with the case where set is not builtin function, and divided the case where the short-circuit should occur.
Removed the last testcase of print(f"{ {set(a for a in 'abc')} }") test as this is invalid as a python code, but should I keep this?

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for following up on it!

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Mar 26, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) March 26, 2024 03:51
@charliermarsh charliermarsh enabled auto-merge (squash) March 26, 2024 03:51
@charliermarsh charliermarsh merged commit a28776e into astral-sh:main Mar 26, 2024
17 checks passed
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@boolean-light boolean-light deleted the unnecessary-generator-set branch March 29, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants