Correctly handle references in __all__ definitions when renaming symbols in autofixes
#10527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
bug
AlexWaygood
force-pushed
the
pyi025-incorrect-fix
branch
from
343814f
to
c85be69
Compare
|
…mbols in autofixes
AlexWaygood
force-pushed
the
pyi025-incorrect-fix
branch
from
c85be69
to
7e7e801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is stacked on top of #10525 -- review that one first!
This PR changes the logic in
ruff_linter/src/renamer.rsto correctly rename references to symbols if those references are string references inside__all__definitions. In order for the renamer to be able to distinguish between__all__references (which need to have their quotes stripped before they can be renamed) and other references, a new flag is added to theSemanticModelFlagsbitflag,DUNDER_ALL_DEFINITION. This flag is inserted into the semantic model when the model is visiting the r.h.s. of an__all__definition.Fixes #10508
Test Plan
Several new test cases have been added for PYI025. These include
__all__definitions with triple-quoted strings, raw strings and implicitly concatenated strings.