Fix subscript comment placement with parenthesized value #10496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
fix-subscript-with-parenthesized-value
branch
from
3d16d20
to
be5bcee
Compare
MichaReiser
added
internal
|
MichaReiser
force-pushed
the
fix-subscript-with-parenthesized-value
branch
from
be5bcee
to
475e812
Compare
charliermarsh
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up on #10492
I incorrectly assumed that
subscript.value.end()always points past the value. However, this isn't the case for parenthesized values where the end "ends" before the parentheses.Test Plan
I added new tests for the parenthesized case.