Avoid incorrect tuple transformation in single-element case (C409)
#10491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WindowGenerator
force-pushed
the
fix-unnecessary-literal-within-tuple-call
branch
from
1b83088
to
41107a8
Compare
|
| // Replace [1, 2] -> (1, 2) or [1] -> (1,) | ||
| let tuple: String = if let [elt] = elts.as_slice() { | ||
| let elt: &str = checker.locator().slice(elt); | ||
| format!("({elt},)") |
There was a problem hiding this comment.
This is going to lose the spacing around the element. Can you take a look at how we solved this in #10461?
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you for suggestion!
…essary-literal-within-tuple-call)
WindowGenerator
force-pushed
the
fix-unnecessary-literal-within-tuple-call
branch
from
41107a8
to
81b8b3a
Compare
charliermarsh
changed the title
C409)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed: incorrect rule transformation rule C409 with single element.
Test Plan
Added examples from #10323 to test fixtures.