Consider raw source code for W605
#10480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
commented
Mar 19, 2024
Comment on lines
-74
to
+75
| let Some(range) = indexer.fstring_ranges().innermost(token_range.start()) else { | ||
| let Some(f_string_range) = indexer.fstring_ranges().innermost(token_range.start()) | ||
| else { |
There was a problem hiding this comment.
Just to be explicit that this is the entire f-string range.
charliermarsh
approved these changes
Mar 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a panic in the linter for
W605.Consider the following f-string:
f"{{}}ab"The
FStringMiddletoken would contain{}ab. Notice that the escaped braces have reduced the string. This means we cannot use the text value from the token to determine the location of the escape sequence but need to extract it from the source code.fixes: #10434
Test Plan
Add new test cases and update the snapshots.