Fix E231 bug: Inconsistent catch compared to pycodestyle, such as when dict nested in list

[augustelalande]

Summary

Fix E231 bug: Inconsistent catch compared to pycodestyle, such as when dict nested in list. Resolves #10113.

Test Plan

Example from #10113 added to test fixture.

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

[MichaReiser]

Thanks for looking into this. Using a stack here makes sense. I'm surprised that this isn't hitting performance more, considering that we're now allocating a new Vec for each logical line (actually two).

[augustelalande]

Thanks for looking into this. Using a stack here makes sense. I'm surprised that this isn't hitting performance more, considering that we're now allocating a new Vec for each logical line (actually two).

Ya it's surprising. But is allocating a new Vec really significantly more expensive than allocating any other variable, if it's not populated?

[augustelalande]

Took inspiration from extraneous_whitespace.rs and reduced it to one stack

[MichaReiser]

Ya it's surprising. But is allocating a new Vec really significantly more expensive than allocating any other variable, if it's not populated?

That's correct: Creating an empty Vec is "free" because it doesn't allocate. But a Vec is different from e.g. a TextSize in that it allocates memory on the heap when you push the first element. That's different from a TextSize variable that is always stored on the stack (which is as cheap as memory can be)

Took inspiration from extraneous_whitespace.rs and reduced it to one stack

Nice, thank you

[MichaReiser]

I find this much easier to understand. Nice refactor