Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint] Implement nonlocal-and-global (E115) #10407

Merged
merged 4 commits into from Mar 18, 2024
Merged

[pylint] Implement nonlocal-and-global (E115) #10407

merged 4 commits into from Mar 18, 2024

Conversation

boolean-light
Copy link
Contributor

Summary

Implement E115 in the issue #970.
Reference to pylint docs: https://pylint.readthedocs.io/en/stable/user_guide/messages/error/nonlocal-and-global.html
Throws an error when a variable name is both declared as global and nonlocal

Test Plan

With nonlocal_and_global.py

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh self-requested a review March 18, 2024 00:28
@charliermarsh charliermarsh added rule Implementing or modifying a lint rule preview Related to preview mode features labels Mar 18, 2024
charliermarsh
charliermarsh approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh enabled auto-merge (squash) March 18, 2024 00:36
@charliermarsh charliermarsh merged commit fd26b29 into astral-sh:main Mar 18, 2024
17 checks passed
@boolean-light boolean-light deleted the nonlocal-and-global branch March 18, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boolean-light @charliermarsh