Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pycodestyle] Do not ignore lines before the first logical line in blank lines rules. #10382

Merged
merged 3 commits into from Mar 14, 2024
Merged

[pycodestyle] Do not ignore lines before the first logical line in blank lines rules. #10382

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78ca1d2
Do not skip line check for lines before first logical line.
hoel-bagard Mar 13, 2024
7d4c6b5
add fixtures about the first line/beginning of the file for the E303 …
hoel-bagard Mar 14, 2024
831d895
add fixtures about the first line/beginning of the file for the E302 …
hoel-bagard Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/ruff_linter/src/rules/pycodestyle/rules/blank_lines.rs
View file
Open in desktop
Expand Up @@ -696,9 +696,7 @@ impl<'a> BlankLinesChecker<'a> {
state.class_status.update(&logical_line);
state.fn_status.update(&logical_line);

if state.is_not_first_logical_line {
self.check_line(&logical_line, &state, prev_indent_length, diagnostics);
}
self.check_line(&logical_line, &state, prev_indent_length, diagnostics);

match logical_line.kind {
LogicalLineKind::Class => {
Expand Down Expand Up @@ -818,6 +816,8 @@ impl<'a> BlankLinesChecker<'a> {
&& line.kind.is_class_function_or_decorator()
// Blank lines in stub files are used to group definitions. Don't enforce blank lines.
&& !self.source_type.is_stub()
// Do not expect blank lines before the first logical line.
&& state.is_not_first_logical_line
{
// E302
let mut diagnostic = Diagnostic::new(
Expand Down